[WICKET-1876] RequestUtils.decodeParameters(String, ValueMap) doesn't follow the Servlet spec

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.3.4
• Fix Version/s: 1.4-RC2
• Component/s: wicket
• Environment: Any
• Assignee: Juegen Donnerstag
• Reporter: Martin Grigorov (Inactive)
• Created: 16/Oct/08 14:39
• Updated: 29/Dec/08 23:19
• Resolved: 20/Dec/08 20:03

Description

RequestUtils.decodeParameters(String, ValueMap) fills a (Value)Map with values of type java.lang.String while it
has to fill values of type String[] because by Servlet API java.servlet.ServletRequest.getParameterValues(String) returns String[].

How I get to this:
mockHttpServletRequest.setUrl("http://dummy.com?param1=value1") -> this calls RequestUtils.decodeParameters(queryString, parameters);
Later when I do mockHttpServletRequest.getParameterMap() and iterate over it I expect the values to be of type String[].

A trivial (and wrong) fix would be to put "new String[]

{currentValue}

" in the map. The proper fix is to collect all values per parameter name and create an array of them.