Thanks for the patch Ate! Cheers for the elaboration on the naming, makes more sense now.
Yup - just get around to it when you can, my understanding is pretty reasonable at this stage.
I take it that where you have removed my FIXME tags, you deem my javadoc comment is pretty complete and accurate.
I have some more comment patchy goodness in my workspace (some clean up, some elaboration), but I will only include that in the portal20 patch as it's becoming more coupled and difficult to separate easily. I will submit a patch to
WICKET-1620 this week, which will include the javadoc.