Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4-M3
    • Fix Version/s: 1.4-RC2
    • Component/s: wicket
    • Labels:
      None

      Description

      Have already done a bit of work on this, will put up a patch shortly.

        Activity

        Hide
        astubbs Antony Stubbs added a comment -

        initial javadoc cut - please review FIXME javadoc locations....

        Show
        astubbs Antony Stubbs added a comment - initial javadoc cut - please review FIXME javadoc locations....
        Hide
        ivaynberg Igor Vaynberg added a comment -

        all the fixmes are portal-related right? should we assign this to ate then?

        Show
        ivaynberg Igor Vaynberg added a comment - all the fixmes are portal-related right? should we assign this to ate then?
        Hide
        adouma Ate Douma added a comment -

        I already took over

        I'll review the javadocs sometime this week

        Show
        adouma Ate Douma added a comment - I already took over I'll review the javadocs sometime this week
        Hide
        ivaynberg Igor Vaynberg added a comment -

        fyi i already applied the patch.

        Show
        ivaynberg Igor Vaynberg added a comment - fyi i already applied the patch.
        Hide
        adouma Ate Douma added a comment -

        LOL
        I wasn't aware of that.
        Well, I'll review anyway, OK?

        Show
        adouma Ate Douma added a comment - LOL I wasn't aware of that. Well, I'll review anyway, OK?
        Hide
        ivaynberg Igor Vaynberg added a comment -

        yep, there are fixmes in there that are all you

        Show
        ivaynberg Igor Vaynberg added a comment - yep, there are fixmes in there that are all you
        Hide
        astubbs Antony Stubbs added a comment -

        Thanks guys - Ate, looking forward to your comments.

        There is more inline documentation and some refactoring, but I will include that in the patch for WICKET-1620.

        Show
        astubbs Antony Stubbs added a comment - Thanks guys - Ate, looking forward to your comments. There is more inline documentation and some refactoring, but I will include that in the patch for WICKET-1620 .
        Hide
        adouma Ate Douma added a comment -

        Antony, I didn't have much time last week, nor will I have the next two weeks until after ApacheCon.
        I just did commit some improvements on the RequestContext javadoc though.
        I will try to review more this week, bit by bit.

        Show
        adouma Ate Douma added a comment - Antony, I didn't have much time last week, nor will I have the next two weeks until after ApacheCon. I just did commit some improvements on the RequestContext javadoc though. I will try to review more this week, bit by bit.
        Hide
        astubbs Antony Stubbs added a comment -

        Thanks for the patch Ate! Cheers for the elaboration on the naming, makes more sense now.
        Yup - just get around to it when you can, my understanding is pretty reasonable at this stage.

        I take it that where you have removed my FIXME tags, you deem my javadoc comment is pretty complete and accurate.

        I have some more comment patchy goodness in my workspace (some clean up, some elaboration), but I will only include that in the portal20 patch as it's becoming more coupled and difficult to separate easily. I will submit a patch to WICKET-1620 this week, which will include the javadoc.

        Show
        astubbs Antony Stubbs added a comment - Thanks for the patch Ate! Cheers for the elaboration on the naming, makes more sense now. Yup - just get around to it when you can, my understanding is pretty reasonable at this stage. I take it that where you have removed my FIXME tags, you deem my javadoc comment is pretty complete and accurate. I have some more comment patchy goodness in my workspace (some clean up, some elaboration), but I will only include that in the portal20 patch as it's becoming more coupled and difficult to separate easily. I will submit a patch to WICKET-1620 this week, which will include the javadoc.

          People

          • Assignee:
            adouma Ate Douma
            Reporter:
            astubbs Antony Stubbs
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development