initial javadoc cut - please review FIXME javadoc locations....

all the fixmes are portal-related right? should we assign this to ate then?

I already took over

I'll review the javadocs sometime this week

fyi i already applied the patch.

LOL
I wasn't aware of that.
Well, I'll review anyway, OK?

yep, there are fixmes in there that are all you

Thanks guys - Ate, looking forward to your comments.

There is more inline documentation and some refactoring, but I will include that in the patch for WICKET-1620.

Antony, I didn't have much time last week, nor will I have the next two weeks until after ApacheCon.
I just did commit some improvements on the RequestContext javadoc though.
I will try to review more this week, bit by bit.

Thanks for the patch Ate! Cheers for the elaboration on the naming, makes more sense now.
Yup - just get around to it when you can, my understanding is pretty reasonable at this stage.

I take it that where you have removed my FIXME tags, you deem my javadoc comment is pretty complete and accurate.

I have some more comment patchy goodness in my workspace (some clean up, some elaboration), but I will only include that in the portal20 patch as it's becoming more coupled and difficult to separate easily. I will submit a patch to WICKET-1620 this week, which will include the javadoc.