Wicket
  1. Wicket
  2. WICKET-1816

Wicket 1.3.4 violates servlet standard, Glassfish spews warnings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.4
    • Fix Version/s: 1.3.5, 1.4-RC1
    • Component/s: wicket
    • Labels:
      None

      Description

      WicketFilter.java line 194 invokes getLastModified() which invokes "request.getParameterMap()" on line 962. Later on in that same request, WicketFilter.java line 222 invokes doGet() which invokes response.setCharacterEncoding() on line 376.

      This is just one case where this problem occurs but I believe others might exist. Whenever Wicket violates the standard Glassfish spews out this warning:

      PWC4011: Unable to set request character encoding to UTF-8 from context <context-path>, because request parameters have already been read, or ServletRequest.getReader() has already been called

      ... you literally end up with tens of these warnings per request, and supposedly, the wrong behavior Glassfish's FAQ discusses this in more detail: http://wiki.glassfish.java.net/Wiki.jsp?page=FaqWebAppUnableToSetRequestCharEncoding

        Issue Links

          Activity

          Hide
          Igor Vaynberg added a comment -

          johan said he committed something that shouldve fixed this on the list, please reopen if its still broken

          Show
          Igor Vaynberg added a comment - johan said he committed something that shouldve fixed this on the list, please reopen if its still broken
          Hide
          Gili added a comment -

          I verified Johan's fix. It seems to solve the problem on my end.

          Show
          Gili added a comment - I verified Johan's fix. It seems to solve the problem on my end.

            People

            • Assignee:
              Igor Vaynberg
              Reporter:
              Gili
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development