[WICKET-1728] remove obsolete check from LocalizedImageResource

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.5, 1.4-RC1
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: Peter Ertl
• Created: 03/Jul/08 09:25
• Updated: 11/Jul/08 15:48
• Resolved: 11/Jul/08 15:48

Description

LocalizedImageResource contains an unnecessary check for parent-relative resources that is not needed anymore:

WicketRuntimeException: "The 'src' attribute must not contain
any of the following strings: '..', './', '/.': ........

Since WICKET-1428 was successfully closed wicket can handle parent-relative (..) links (in both 1.3 and 1.4).

So please remove this check:

org.apache.wicket.markup.html.image.resource.LocalizedImageResource:

private void loadStaticImage(final String path)
{
if ((path.indexOf("..") != -1) || (path.indexOf("./") != -1) || (path.indexOf("/.") != -1))

{ throw new WicketRuntimeException( "The 'src' attribute must not contain any of the following strings: '..', './', '/.': path=" + path); }

// .... SNIP ....
}

I did several tests with 1.3 and 1.4. Everything works like a charm now (once that nasty check is away