[WICKET-1711] Improve Locale fallback in BundleStringResourceLoader

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.3, 1.4-M2
• Fix Version/s: 1.3.4, 1.4-M3
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: Jonas
• Created: 20/Jun/08 14:48
• Updated: 20/Jun/08 16:05
• Resolved: 20/Jun/08 16:05

Description

While https://issues.apache.org/jira/browse/WICKET-1415 fixed the NPE in BundleStringResourceLoader,
Locale.getDefault() is a bad choice to get the locale from, as it is determined by the default locale of the jvm
running the servlet container. I think it's a big coincidence if the jvm default locale is actually the one the user wants
to see in the webapp - Session#getLocale() would probably be a better default.

Attached is a patch against current trunk (1.4)