Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.3
    • Fix Version/s: 1.3.5
    • Component/s: wicket
    • Labels:
      None

      Description

      No entries are removed from DiskPageStore.sessionIdToEntryMap. I guess, this should be added to the DiskPageStore.unbind(String sessionId) method:

      public void unbind(String sessionId)
      {
      // FIX: replace get() with remove()
      SessionEntry entry = (SessionEntry)sessionIdToEntryMap.get(sessionId);
      if (entry != null)
      {
      if (isSynchronous())

      { entry.unbind(); }

      else
      {
      List pages = getPagesToSaveList(sessionId);
      synchronized (pages)

      { flushPagesToSaveList(sessionId, pages); entry.unbind(); }

      pagesToSaveAll.remove(sessionId);
      }
      }
      }

        Activity

        Show
        Stefan Fussenegger added a comment - see also http://www.nabble.com/Memory-leak-in-DiskPageStore-td17597466.html
        Hide
        Stefan Fussenegger added a comment -

        I had my proposed fix in production for while now and it works very well. Could this please be fixed? It absolutely is a no-brainer!

        Show
        Stefan Fussenegger added a comment - I had my proposed fix in production for while now and it works very well. Could this please be fixed? It absolutely is a no-brainer!
        Hide
        Matej Knopp added a comment -

        Sorry for the delay, i thought the fix was backported to1.3 already

        Show
        Matej Knopp added a comment - Sorry for the delay, i thought the fix was backported to1.3 already

          People

          • Assignee:
            Matej Knopp
            Reporter:
            Stefan Fussenegger
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25h
              0.25h
              Remaining:
              Remaining Estimate - 0.25h
              0.25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development