Wicket
  1. Wicket
  2. WICKET-1249

modal.js conflicts with mootools and possibly other javascript frameworks. + patch fix

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0-rc2
    • Fix Version/s: 1.3.1
    • Component/s: wicket-extensions
    • Labels:
      None
    • Environment:
      linux / jdk 1.6 etc

      Description

      Modal.js issues

      1. Modal.js defines Class instead of Wicket.Class. Modal.js tries to define new Wicket classes via Class instead of Wicket.Class.xxx.
      2. Object.extend conflicts with mootools, so I created a new Wicket class Wicket.Object with an extend method.

      Here is the patch against wicket-extensions trunk. This works perfectly with mootools-trunk

      http://temp.fabulously40.com/~victori/modalconflictfix.patch

        Activity

        Hide
        Igor Vaynberg added a comment -

        it would be great if you could attach that patch to this jira issue as an attachment and check the "attach under asl2" attachment option. that makes it much easier licensing wise for us to integrate that patch directly.

        Show
        Igor Vaynberg added a comment - it would be great if you could attach that patch to this jira issue as an attachment and check the "attach under asl2" attachment option. that makes it much easier licensing wise for us to integrate that patch directly.
        Hide
        Victor Igumnov added a comment -

        patch fix

        Show
        Victor Igumnov added a comment - patch fix

          People

          • Assignee:
            Matej Knopp
            Reporter:
            Victor Igumnov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development