[WICKET-1171] Tolerate malformed If-Modified-Since header

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.0-rc1
• Fix Version/s: 1.3.0-rc2
• Component/s: wicket
• Assignee: Unassigned
• Reporter: Nathan Hamblen
• Created: 20/Nov/07 02:18
• Updated: 20/Nov/07 05:20
• Resolved: 20/Nov/07 05:20

Description

Some kind of RSS aggregator is hitting an rc1 site of mine regularly with dates that don't follow the HTTP spec. Correct to the servlet spec, Jetty throws an exception in this instance which causes Wicket to abort processing the request and log an error. I think it would be better to log the exception as a warning and proceed as if the header had not been present.

Example exception:

ERROR btpool0-703 org.mortbay.log - /resources/com.typeturner.Typeturner/eat-rss
java.lang.IllegalArgumentException: Cannot convert date: 1194673976
at org.mortbay.jetty.HttpFields.getDateField(HttpFields.java:827)
at org.mortbay.jetty.Request.getDateHeader(Request.java:460)
at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:197)