Whirr
  1. Whirr
  2. WHIRR-717

Make use of the context name in the dynamic compute cache.

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: core
    • Labels:
      None

      Description

      It would be a good idea to allow the dynamic compute cache to use the context name (which can uniquely identify a context) so that it can reuse existing contexts.

      1. WHIRR-717-2.patch
        19 kB
        Ioannis Canellos
      2. WHIRR-717.patch
        41 kB
        Ioannis Canellos

        Activity

        Hide
        Ioannis Canellos added a comment -

        This patch improves the dynamic compute cache to use the context name instead of a generated key. This makes reuse of existing compute service easier.

        It also improves the handling of context name in the karaf commands.

        Show
        Ioannis Canellos added a comment - This patch improves the dynamic compute cache to use the context name instead of a generated key. This makes reuse of existing compute service easier. It also improves the handling of context name in the karaf commands.
        Hide
        Ioannis Canellos added a comment -

        While working on this patch I had a small issue with the ClusterControllerFactory and turned it into an interface, with a basic implementation the BaseClusterControllerFactory. It seemed trivial to get it to a separate patch.

        Show
        Ioannis Canellos added a comment - While working on this patch I had a small issue with the ClusterControllerFactory and turned it into an interface, with a basic implementation the BaseClusterControllerFactory. It seemed trivial to get it to a separate patch.
        Hide
        Andrew Bayer added a comment -

        As I said on IRC, I'd really like to not change ClusterControllerFactory to an interface, at least not in 0.8.2. That's a fairly major API change for services/commands/etc, and could create some real problems for any custom services/commands.

        Show
        Andrew Bayer added a comment - As I said on IRC, I'd really like to not change ClusterControllerFactory to an interface, at least not in 0.8.2. That's a fairly major API change for services/commands/etc, and could create some real problems for any custom services/commands.
        Hide
        Ioannis Canellos added a comment -

        Makes, sense I'll work around that.

        Show
        Ioannis Canellos added a comment - Makes, sense I'll work around that.
        Hide
        Ioannis Canellos added a comment -

        Attaching a new version of the patch, that doesn't contain the change of the ClusterControllerFactory.

        Show
        Ioannis Canellos added a comment - Attaching a new version of the patch, that doesn't contain the change of the ClusterControllerFactory.
        Hide
        Andrew Bayer added a comment -

        +1 - looks good, core and karaf tests pass.

        Show
        Andrew Bayer added a comment - +1 - looks good, core and karaf tests pass.

          People

          • Assignee:
            Ioannis Canellos
            Reporter:
            Ioannis Canellos
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development