Whirr
  1. Whirr
  2. WHIRR-7

Add a ZooKeeper service to the cloud scripts

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: contrib/python
    • Labels:
      None

      Description

      It would be good to add other Hadoop services to the cloud scripts.

        Activity

        Hide
        Tom White added a comment -

        Patch implementing a basic ZooKeeper service.

        Show
        Tom White added a comment - Patch implementing a basic ZooKeeper service.
        Hide
        steve_l added a comment -

        Are you in danger of creating a dependency loop here?

        What might be interesting is to do a downstream project, "deployment" or some witty name that handles this and the other package/release/functional testing stuff.

        Show
        steve_l added a comment - Are you in danger of creating a dependency loop here? What might be interesting is to do a downstream project, "deployment" or some witty name that handles this and the other package/release/functional testing stuff.
        Hide
        Tom White added a comment -

        > Are you in danger of creating a dependency loop here?

        Not really. There is no compile-time dependency here. The scripts already run HDFS and MapReduce clusters, which are not contained in Hadoop Common. HOD does this too.

        Having said that, if people think this is a problem then we can move the scripts.

        Show
        Tom White added a comment - > Are you in danger of creating a dependency loop here? Not really. There is no compile-time dependency here. The scripts already run HDFS and MapReduce clusters, which are not contained in Hadoop Common. HOD does this too. Having said that, if people think this is a problem then we can move the scripts.
        Hide
        Henry Robinson added a comment -

        +1 looks perfectly sane to me. ZooKeeper specifics look good. There are a couple of Python idioms that won't work with 2.4 (with statement, particularly, is not available pre 2.5), and if that's not a problem then in a couple of places I think a defaultdict (http://docs.python.org/library/collections.html#collections.defaultdict) would be more Pythonic. However, in general, looks great to me.

        Show
        Henry Robinson added a comment - +1 looks perfectly sane to me. ZooKeeper specifics look good. There are a couple of Python idioms that won't work with 2.4 (with statement, particularly, is not available pre 2.5), and if that's not a problem then in a couple of places I think a defaultdict ( http://docs.python.org/library/collections.html#collections.defaultdict ) would be more Pythonic. However, in general, looks great to me.
        Hide
        Tom White added a comment -

        Thanks for the review, Henry.

        If we need to target Python 2.4 (for RHEL 5 compatibility, for instance) then it should be done as a part of another issue, since there are other places in the scripts where there are Python 2.5-isms.

        I'll commit this in the next few days, unless there are objections.

        Show
        Tom White added a comment - Thanks for the review, Henry. If we need to target Python 2.4 (for RHEL 5 compatibility, for instance) then it should be done as a part of another issue, since there are other places in the scripts where there are Python 2.5-isms. I'll commit this in the next few days, unless there are objections.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12428844/HADOOP-6466.patch
        against trunk revision 895831.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428844/HADOOP-6466.patch against trunk revision 895831. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/253/console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this.

        I tested this change manually, by starting and stopping a ZooKeeper cluster.

        Show
        Tom White added a comment - I've just committed this. I tested this change manually, by starting and stopping a ZooKeeper cluster.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #134 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/134/)
        . Add a ZooKeeper service to the cloud scripts.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #134 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/134/ ) . Add a ZooKeeper service to the cloud scripts.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #210 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/210/)
        . Add a ZooKeeper service to the cloud scripts.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #210 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/210/ ) . Add a ZooKeeper service to the cloud scripts.

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development