Re: CreateSitePpAndApplyRolesTest – absolutely! Attached is a new patch with the unit test updated. Sorry for not updating it to begin with.
As to how this feature is going to be used (and perhaps we need to put this in docs some place) – it allows individual puppet agents discover the topology of the cluster (IOW, what classes are applied to what nodes) and makes decisions based on that. Here's how it will work on the puppet side (using Zookeeper as an example):
$ensemble = extlookup('zookeeper::server', ['127.0.0.1'])
and later on in the configuration file template:
<% ensemble.each_with_index do |server,idx| %>
server.<%= idx %>=<%= server %>
<% end %>
That's the general idea.
Now, I'm still tweaking this patch as far as the best integration with Puppet is concerned (hence not putting it into a 'Patch Submitted' state but simply asking for early feedback). I'm rewriting Bigtop Puppet code as part of this as well.
Finally, as for WHIRR-516 – this JIRA is required to make progress on WHIRR-516. My ultimate goal as far as WHIRR-516 is concerned is to be able to deploy Bigtop clusters by a simple:
Hope this answers your questions and, once again, thanks for the feedback – much appreciated!
P.S. Feel free to add me to the project so I can assign these JIRAs to myself.