Whirr
  1. Whirr
  2. WHIRR-646

Integration tests should have failsafe timeouts

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.1, 0.9.0
    • Component/s: build
    • Labels:
      None

      Description

      Currently, we're not checking for timeouts on integration test execution, meaning that if one test hangs, the whole build is borked. We should fix that.

      1. WHIRR-646.patch
        0.8 kB
        Andrew Bayer

        Activity

        Hide
        Andrew Bayer added a comment -

        This patch adds a 60 minute timeout for forked integration tests - we're using the default forkMode of "once", so this timeout would be for all the tests in a given module. I can't see anything needing close to 60 minutes for a single module's integration tests barring something going wrong (in which case we want it to be killed by failsafe here anyway), so I think this is good. Also bumped the surefire and failsafe version to the latest, 2.12.

        Show
        Andrew Bayer added a comment - This patch adds a 60 minute timeout for forked integration tests - we're using the default forkMode of "once", so this timeout would be for all the tests in a given module. I can't see anything needing close to 60 minutes for a single module's integration tests barring something going wrong (in which case we want it to be killed by failsafe here anyway), so I think this is good. Also bumped the surefire and failsafe version to the latest, 2.12.
        Hide
        Andrei Savu added a comment -

        +1

        Show
        Andrei Savu added a comment - +1
        Hide
        Tom White added a comment -

        I just committed this. Thanks Andrew!

        Show
        Tom White added a comment - I just committed this. Thanks Andrew!

          People

          • Assignee:
            Andrew Bayer
            Reporter:
            Andrew Bayer
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development