Whirr
  1. Whirr
  2. WHIRR-633

Align jclouds 1.5.0 modularity changes with Whirr

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Now that whirr is finally using jclouds 1.5.x, which contains great improvements regarding OSGi, I'd like to align whirr accordingly.

      As of jclouds 1.5.0 the scriptloader, inside OSGi will leverage services in order to load script and no longer considers flat classloaders.
      This allows some significant improvements in whirr:

      i) No longer use of OSGi fragments is required.
      ii) Since we no longer need fragments we can have proper bundles that can have an activator and no longer need blueprint.

      1. osgi-improvements-with-more-activators.patch
        262 kB
        Ioannis Canellos
      2. osgi-improvements-with-activators.patch
        246 kB
        Ioannis Canellos
      3. osgi-improvements.patch
        178 kB
        Ioannis Canellos
      4. osgi-improvements.diff
        81 kB
        Ioannis Canellos

        Activity

        Hide
        Ioannis Canellos added a comment -

        I am attaching a patch which aligns whirr with jclouds 1.5.0 osgi related changes.

        It also updates the out of date feature descriptor and finally it provides some missing features.

        Also updates itests.

        Show
        Ioannis Canellos added a comment - I am attaching a patch which aligns whirr with jclouds 1.5.0 osgi related changes. It also updates the out of date feature descriptor and finally it provides some missing features. Also updates itests.
        Hide
        Ioannis Canellos added a comment -

        Attaching a (hopefully) more complete version of the patch that is aligned with the latest trunk.

        Show
        Ioannis Canellos added a comment - Attaching a (hopefully) more complete version of the patch that is aligned with the latest trunk.
        Hide
        Ioannis Canellos added a comment -

        Added the activator classes

        Show
        Ioannis Canellos added a comment - Added the activator classes
        Hide
        Adrian Cole added a comment -

        I applied the latest patch:

        patch -p0 --input /path/to/osgi-improvements-with-activators.patch

        Next, I removed the zero-length files:

        svn rm --force services/voldemort/src/main/resources/OSGI-INF/blueprint/blueprint.xml core/src/main/resources/OSGI-INF/blueprint/blueprint.xml

        Then, I ran the tests:

        mvn clean install eclipse:eclipse -Posgi

        It fails with the message:

        [INFO] — maven-bundle-plugin:2.3.6:bundle (default-bundle) @ whirr-core —
        [ERROR] Bundle org.apache.whirr:whirr-core:bundle:0.9.0-SNAPSHOT : Bundle-Activator not found on the bundle class path nor in imports: org.apache.whirr.osgi.Activator

        Show
        Adrian Cole added a comment - I applied the latest patch: patch -p0 --input /path/to/osgi-improvements-with-activators.patch Next, I removed the zero-length files: svn rm --force services/voldemort/src/main/resources/OSGI-INF/blueprint/blueprint.xml core/src/main/resources/OSGI-INF/blueprint/blueprint.xml Then, I ran the tests: mvn clean install eclipse:eclipse -Posgi It fails with the message: [INFO] — maven-bundle-plugin:2.3.6:bundle (default-bundle) @ whirr-core — [ERROR] Bundle org.apache.whirr:whirr-core:bundle:0.9.0-SNAPSHOT : Bundle-Activator not found on the bundle class path nor in imports: org.apache.whirr.osgi.Activator
        Hide
        Ioannis Canellos added a comment -

        name says all

        Show
        Ioannis Canellos added a comment - name says all
        Hide
        Adrian Cole added a comment -

        +1

        Following steps work!

        patch -p0 --input /path/to/osgi-improvements-with-more-activators.patch
        find . -name blueprint.xml -size 0 -exec svn rm --force {} \;
        mvn clean install eclipse:eclipse -Posgi

        Next step: apply to trunk, then the release branch

        Show
        Adrian Cole added a comment - +1 Following steps work! patch -p0 --input /path/to/osgi-improvements-with-more-activators.patch find . -name blueprint.xml -size 0 -exec svn rm --force {} \; mvn clean install eclipse:eclipse -Posgi Next step: apply to trunk, then the release branch
        Hide
        Adrian Cole added a comment -

        trunk:
        Committed revision 1374643.

        next up: release branch

        Show
        Adrian Cole added a comment - trunk: Committed revision 1374643. next up: release branch
        Hide
        Adrian Cole added a comment -

        release branch passes!

        Show
        Adrian Cole added a comment - release branch passes!
        Hide
        Adrian Cole added a comment -

        thanks, ioannis

        Show
        Adrian Cole added a comment - thanks, ioannis

          People

          • Assignee:
            Ioannis Canellos
            Reporter:
            Ioannis Canellos
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development