Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: service/cdh
    • Labels:
      None

      Description

      Various properties files specify whirr.env.repo=cdh4

      I try to use CDH3 by specifying whirr.env.repo=cdh3 (default is cdh4), but it doesn't work. Looking in the scripts, a variable $REPO is used, and specifying whirr.env.REPO=cdh3 (uppercase repo) makes it work for me.

      Looking around, it seems whirr.env.repo got introduced in WHIRR-415, and the usage of $REPO probably predates that.

      I'm not entirely sure if the lowercase variant serves a purpose, I would guess it does otherwise WHIRR-415 makes little sense.

      Maybe someone can shine some light one this, and then we can adjust the sample/test properties files accordingly.

      1. WHIRR-610.patch
        3 kB
        Andrew Bayer

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          3d 8h 3m 1 Andrew Bayer 03/Aug/12 23:55
          Patch Available Patch Available Resolved Resolved
          1d 17h 23m 1 Adrian Cole (Inactive) 05/Aug/12 17:18
          Adrian Cole (Inactive) made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.8.0 [ 12321649 ]
          Resolution Fixed [ 1 ]
          Hide
          Adrian Cole (Inactive) added a comment -

          Committed revision 1369614.

          Show
          Adrian Cole (Inactive) added a comment - Committed revision 1369614.
          Hide
          Adrian Cole (Inactive) added a comment -

          did a code search and this is the only place where the env properties are in the wrong case.

          Show
          Adrian Cole (Inactive) added a comment - did a code search and this is the only place where the env properties are in the wrong case.
          Adrian Cole (Inactive) made changes -
          Link This issue blocks WHIRR-612 [ WHIRR-612 ]
          Andrew Bayer made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Andrew Bayer made changes -
          Attachment WHIRR-610.patch [ 12539113 ]
          Andrew Bayer made changes -
          Field Original Value New Value
          Assignee Andrew Bayer [ abayer ]
          Hide
          Andrew Bayer added a comment -

          Yeah, I think I have a patch sitting around for this. Will check right now.

          Show
          Andrew Bayer added a comment - Yeah, I think I have a patch sitting around for this. Will check right now.
          Hide
          Andrei Savu added a comment -

          Yep.

          Show
          Andrei Savu added a comment - Yep.
          Hide
          Bruno Dumon added a comment -

          So IIUC uppercase should be used now, and thus we need to adjust the properties files?

          Show
          Bruno Dumon added a comment - So IIUC uppercase should be used now, and thus we need to adjust the properties files?
          Hide
          Andrei Savu added a comment -

          This behaviour change was introduced in jclouds 1.5.0-beta.x. The naming convention for environment variables changed from somethingLikeThis to SOMETHING_LIKE_THIS.

          Show
          Andrei Savu added a comment - This behaviour change was introduced in jclouds 1.5.0-beta.x. The naming convention for environment variables changed from somethingLikeThis to SOMETHING_LIKE_THIS.
          Bruno Dumon created issue -

            People

            • Assignee:
              Andrew Bayer
              Reporter:
              Bruno Dumon
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development