Whirr
  1. Whirr
  2. WHIRR-587

Update version of jopt-simple (from 3.2 to 4.3)

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      The version of jopt-simple (in cli/pom.xml, core/pom.xml and examples/pom.xml) is 3.2.

      I'm working on github.com/brooklyncentral/brooklyn, which has a dependency on Whirr. I'd like to use the most recent jopt-simple (version 4.3) but this leads to the obvious classpath issues.


      Interesting, platforms/karaf/feature/pom.xml has:
      <jopt.simple.bundle.version>4.3_1</jopt.simple.bundle.version>

      Does that mean if you use whirr in a Karaf OSGi container, it will be using 4.3 already?!

        Activity

        Aled Sage created issue -
        Hide
        Andrei Savu added a comment -

        Is 4.3 backwards compatible or we need to make code changes?

        Show
        Andrei Savu added a comment - Is 4.3 backwards compatible or we need to make code changes?
        Hide
        Aled Sage added a comment -

        From http://pholser.github.com/jopt-simple/changes.html, looks like its just additions (and internal cleanup) so hopefully backwards compatible.

        I'll try to find some time to try upgrading it soon, and see how it goes...

        Show
        Aled Sage added a comment - From http://pholser.github.com/jopt-simple/changes.html , looks like its just additions (and internal cleanup) so hopefully backwards compatible. I'll try to find some time to try upgrading it soon, and see how it goes...
        Hide
        Andrei Savu added a comment -

        Everything seems to be working fine with 4.3.

        Show
        Andrei Savu added a comment - Everything seems to be working fine with 4.3.
        Andrei Savu made changes -
        Field Original Value New Value
        Attachment WHIRR-587.patch [ 12526128 ]
        Andrei Savu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Andrei Savu [ savu.andrei ]
        Hide
        Andrei Savu added a comment -

        I'm going to commit this small change tonight if there is no objection.

        Show
        Andrei Savu added a comment - I'm going to commit this small change tonight if there is no objection.
        Andrei Savu made changes -
        Fix Version/s 0.8.0 [ 12318880 ]
        Hide
        Tom White added a comment -

        +1 looks fine.

        Show
        Tom White added a comment - +1 looks fine.
        Hide
        Andrei Savu added a comment -

        Committed to trunk. Thanks Tom for checking.

        Show
        Andrei Savu added a comment - Committed to trunk. Thanks Tom for checking.
        Andrei Savu made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Tom White made changes -
        Fix Version/s 0.8.0 [ 12321649 ]
        Fix Version/s 0.8.0-alpha.1 [ 12318880 ]

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Aled Sage
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development