yum install is called without the -y flag.
We might want to use retry_yum, too.
Patch uses yum install -y, installs the right package (openjdk-1.6.0-devel, the regular package contains only jre), correctly sets JAVA_HOME
+1 Looks good - I assume you have tested?
Here's a small update to use retry_yum. I successfully tested by manually starting a cluster.
Uh yes, that was tested. I didn't know if I could trust retry_yum yet, but if it works it works.
I've tried the scripts individually (not from inside whirr) on ubuntu/centos created on aws-ec2 and cloudservers-us and they seem to work fine.
Seems reasonable. I've got some pending changes to the java home detection for supporting Ubuntu 12.04 and CentOS 6, but that should definitely wait for this.
this patch depends on an unmerged change
this is more straight forward to resolve as a part of WHIRR-528, as the point of WHIRR-528 is to change things to retry. The subtle openjdk needs -devl was resolved in WHIRR-613