Whirr
  1. Whirr
  2. WHIRR-556

The message 'running on $PROVIDER using identity $IDENTITY' is confusing

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      The message doesn't always show the right values provider/identity:
      It doesn't take overrides in the whirr config file into account.

      (If you don't work with ~/.whirr/conf you even get a more cryptic message: 'Running on using identity'

      1. WHIRR-556.patch
        8 kB
        Karel Vervaeke

        Activity

        Hide
        Karel Vervaeke added a comment -

        Oops. Patch broke ListClusterCommandTest.testAllOptions() because it didn't expect the 'running on ...' message in the output.
        Fixed that by adding --quiet to the options in the test.

        Show
        Karel Vervaeke added a comment - Oops. Patch broke ListClusterCommandTest.testAllOptions() because it didn't expect the 'running on ...' message in the output. Fixed that by adding --quiet to the options in the test.
        Hide
        Karel Vervaeke added a comment -

        Applied to trunk (r1302828)

        Show
        Karel Vervaeke added a comment - Applied to trunk (r1302828)
        Hide
        Andrei Savu added a comment -

        +1

        Show
        Andrei Savu added a comment - +1
        Hide
        Karel Vervaeke added a comment -

        This patch:

        • makes sure the message is correct (uses clusterSpec.get {Provider,Identity}
        • makes sure the message is displayed only when it makes sense (e.g. not for 'whirr help')
        • allows suppressing the message using --quiet
        Show
        Karel Vervaeke added a comment - This patch: makes sure the message is correct (uses clusterSpec.get {Provider,Identity} makes sure the message is displayed only when it makes sense (e.g. not for 'whirr help') allows suppressing the message using --quiet
        Hide
        Karel Vervaeke added a comment -

        Not unrelated:
        We are processing whirr list-cluster output with awk. We currently ignore the first line, but it would be nice if whirr had added a -q option to suppress the otherwise useless output.

        Show
        Karel Vervaeke added a comment - Not unrelated: We are processing whirr list-cluster output with awk. We currently ignore the first line, but it would be nice if whirr had added a -q option to suppress the otherwise useless output.

          People

          • Assignee:
            Unassigned
            Reporter:
            Karel Vervaeke
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development