Whirr
  1. Whirr
  2. WHIRR-549

Remove dependency on system SSH keys in tests

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7.1
    • Fix Version/s: 0.8.0
    • Component/s: build
    • Labels:
      None

      Activity

      Hide
      Frank Scholten added a comment -

      Some tests call ClusterSpec.withTemporaryKeys() directly like in DestroyClusterCommandTest.testAllOptions()

      However in other tests such as DestroyClusterCommandTest.testInsufficientOptions() the ClusterSpec is created by the command itself and we have no direct control over it.

      Thoughts?

      Show
      Frank Scholten added a comment - Some tests call ClusterSpec.withTemporaryKeys() directly like in DestroyClusterCommandTest.testAllOptions() However in other tests such as DestroyClusterCommandTest.testInsufficientOptions() the ClusterSpec is created by the command itself and we have no direct control over it. Thoughts?
      Hide
      Andrei Savu added a comment -

      We can use the same approach as in DestroyClusterCommandTest.testAllOptions. Something like this:

      Map<String, File> keys = KeyPair.generateTemporaryFiles();
          
      int rc = command.run(null, out, null, Lists.newArrayList(
              "--private-key-file", keys.get("private").getAbsolutePath()
      ));
      
      Show
      Andrei Savu added a comment - We can use the same approach as in DestroyClusterCommandTest.testAllOptions. Something like this: Map<String, File> keys = KeyPair.generateTemporaryFiles(); int rc = command.run(null, out, null, Lists.newArrayList( "--private-key-file", keys.get("private").getAbsolutePath() ));
      Hide
      Frank Scholten added a comment -

      Build is stable again!

      Show
      Frank Scholten added a comment - Build is stable again!
      Hide
      Andrei Savu added a comment -

      Marking as fixed. Thanks Frank for looking into this!

      Show
      Andrei Savu added a comment - Marking as fixed. Thanks Frank for looking into this!
      Hide
      Andrei Savu added a comment -

      Important Note: Next time please attach the patch to the JIRA before committing for review and also make sure you update CHANGES.txt (I will do it now)

      Show
      Andrei Savu added a comment - Important Note : Next time please attach the patch to the JIRA before committing for review and also make sure you update CHANGES.txt (I will do it now)
      Hide
      Tom White added a comment -

      > Build is stable again!

      Great. I'm not sure why the test failures weren't failing the build, but I've made a change which I hope will fix this ("Publish testing tools result report").

      Show
      Tom White added a comment - > Build is stable again! Great. I'm not sure why the test failures weren't failing the build, but I've made a change which I hope will fix this ("Publish testing tools result report").

        People

        • Assignee:
          Frank Scholten
          Reporter:
          Frank Scholten
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development