Whirr
  1. Whirr
  2. WHIRR-536

Using SNAPSHOT versions of jclouds breaks OSGi support

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: build
    • Labels:
      None

      Description

      The problem is simple. Whirr uses fragments that attach themselves to jclouds script builder.
      Maven bundle plugin doesn't cleanup the bundle version used when using fragment instructions.
      OSGi doesn't cope with -SNAPSHOT in versions.

      What needs to be done is to add a plugin configuration that cleans up the version and pass it to the maven-bundle-plugin.

      1. WHIRR-536.patch
        20 kB
        Andrei Savu
      2. WHIRR-536.patch
        16 kB
        Ioannis Canellos

        Activity

        Hide
        Ioannis Canellos added a comment -

        I am attaching a patch, which uses antrun plugin to normalize the jclouds version.

        This patch also removes dependency of guava from itests (compile scope, the tests still require guava in the test scope).

        Patch has been also tested with whirr-504 (it requires to also change the version of jclouds-karaf to fully work, which is not included in this patch).

        Show
        Ioannis Canellos added a comment - I am attaching a patch, which uses antrun plugin to normalize the jclouds version. This patch also removes dependency of guava from itests (compile scope, the tests still require guava in the test scope). Patch has been also tested with whirr-504 (it requires to also change the version of jclouds-karaf to fully work, which is not included in this patch).
        Hide
        Andrei Savu added a comment -

        I still see whirr-core as a test dependency for karaf/itests - can this be a problem? What if getOsgiService does not try to cast and we only check for notNull?

        Show
        Andrei Savu added a comment - I still see whirr-core as a test dependency for karaf/itests - can this be a problem? What if getOsgiService does not try to cast and we only check for notNull?
        Hide
        Andrei Savu added a comment -

        I'm attaching a slightly updated version of this patch that removes whirr-core as a dependency for karaf/itests. All tests are passing. What do you think?

        Show
        Andrei Savu added a comment - I'm attaching a slightly updated version of this patch that removes whirr-core as a dependency for karaf/itests. All tests are passing. What do you think?
        Hide
        Andrei Savu added a comment -

        Committed to trunk. We've discussed the new approach on IRC and everything should be fine.

        Show
        Andrei Savu added a comment - Committed to trunk. We've discussed the new approach on IRC and everything should be fine.

          People

          • Assignee:
            Ioannis Canellos
            Reporter:
            Ioannis Canellos
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development