Whirr
  1. Whirr
  2. WHIRR-526

Don't log harmless sshj errors to console

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.1
    • Component/s: core
    • Labels:
      None

      Description

      It's quite common to see sshj errors in the console during launch.

      Dying because - net.schmizz.sshj.transport.TransportException: Broken transport; encountered EOF
      

      They seem to be harmless since the service starts fine. Let's log them to whirr.log, but not to the console.

      1. log4j-cli.xml
        2 kB
        Andrei Savu
      2. log4j-cli.xml
        2 kB
        Andrei Savu

        Activity

        Tom White created issue -
        Andrei Savu made changes -
        Field Original Value New Value
        Assignee Andrei Savu [ savu.andrei ]
        Andrei Savu made changes -
        Fix Version/s 0.7.1 [ 12319942 ]
        Fix Version/s 0.8.0 [ 12318880 ]
        Hide
        Andrei Savu added a comment -

        What we need to do is redirect both jclouds.ssh & net.schmizz.sshj.transport.TransportImpl to the log file.

        Show
        Andrei Savu added a comment - What we need to do is redirect both jclouds.ssh & net.schmizz.sshj.transport.TransportImpl to the log file.
        Hide
        Andrei Savu added a comment -

        Update log4j settings for cli to display message on the console only for org.apache.whirr and everything else should go into the whirr.log file.

        Show
        Andrei Savu added a comment - Update log4j settings for cli to display message on the console only for org.apache.whirr and everything else should go into the whirr.log file.
        Andrei Savu made changes -
        Attachment log4j-cli.xml [ 12515778 ]
        Andrei Savu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Andrei Savu added a comment -

        This one seems to be even better. All DEBUG messages from org.apache.whirr go to whirr.log as expected.

        Show
        Andrei Savu added a comment - This one seems to be even better. All DEBUG messages from org.apache.whirr go to whirr.log as expected.
        Andrei Savu made changes -
        Attachment log4j-cli.xml [ 12515788 ]
        Hide
        Andrei Savu added a comment -

        Please review! The same file should work both with trunk and branch 0.7

        Show
        Andrei Savu added a comment - Please review! The same file should work both with trunk and branch 0.7
        Hide
        Tom White added a comment -

        +1 it looks good. I tried using it, but didn't get any ssh exceptions on that particular run. Have you seen the ssh exceptions go into the log file?

        Show
        Tom White added a comment - +1 it looks good. I tried using it, but didn't get any ssh exceptions on that particular run. Have you seen the ssh exceptions go into the log file?
        Hide
        Andrei Savu added a comment -

        Thanks Tom for reviewing. You can get a long list of ssh errors by trying to start a zookeeper cluster on t1.micro using 0.7.1 due to some bugs in jclouds (flooding the instance with too many script status requests).

        Show
        Andrei Savu added a comment - Thanks Tom for reviewing. You can get a long list of ssh errors by trying to start a zookeeper cluster on t1.micro using 0.7.1 due to some bugs in jclouds (flooding the instance with too many script status requests).
        Hide
        Andrei Savu added a comment -

        Committed both to trunk and branch 0.7. I will do a final check to see if "unlimited" is a valid value for "mapred.child.ulimit" (as reported on the email list) and build the release candidate for 0.7.1.

        Show
        Andrei Savu added a comment - Committed both to trunk and branch 0.7. I will do a final check to see if "unlimited" is a valid value for "mapred.child.ulimit" (as reported on the email list) and build the release candidate for 0.7.1.
        Andrei Savu made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Andrei Savu made changes -
        Fix Version/s 0.8.0 [ 12318880 ]

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development