Whirr
  1. Whirr
  2. WHIRR-509

Provide live OSGi integration tests

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
    1. WHIRR-509-patch-2.txt
      20 kB
      Ioannis Canellos
    2. WHIRR-509-patch.txt
      21 kB
      Ioannis Canellos
    3. WHIRR-509.patch
      42 kB
      Andrei Savu

      Activity

      Ioannis Canellos created issue -
      Hide
      Ioannis Canellos added a comment -

      I am attaching a patch which adds 2 more OSGi integration tests. These tests are live and run against amazon ec2 and rackspace, if the live profile is specified AND if live profile contains credentials for the each cloud provider. If not the tests will not run or abort without fail respectively.

      The tests use whirr from inside the karaf shell and currently test the zookeeper service.

      Show
      Ioannis Canellos added a comment - I am attaching a patch which adds 2 more OSGi integration tests. These tests are live and run against amazon ec2 and rackspace, if the live profile is specified AND if live profile contains credentials for the each cloud provider. If not the tests will not run or abort without fail respectively. The tests use whirr from inside the karaf shell and currently test the zookeeper service.
      Ioannis Canellos made changes -
      Field Original Value New Value
      Attachment WHIRR-509-patch.txt [ 12514011 ]
      Hide
      Andrei Savu added a comment -

      For consistency reasons I think we should stick to the convention we already have for running integration tests using maven:

      mvn verify -Pintegration \
      -DargLine="-Dwhirr.test.provider=<cloud-provider> -Dwhirr.test.identity=<cloud-provider-user> -Dwhirr.test.credential=<cloud-provider-secret-key>"

      See wiki: https://cwiki.apache.org/confluence/display/WHIRR/How+To+Contribute (Running Tests)

      Show
      Andrei Savu added a comment - For consistency reasons I think we should stick to the convention we already have for running integration tests using maven: mvn verify -Pintegration \ -DargLine="-Dwhirr.test.provider=<cloud-provider> -Dwhirr.test.identity=<cloud-provider-user> -Dwhirr.test.credential=<cloud-provider-secret-key>" See wiki: https://cwiki.apache.org/confluence/display/WHIRR/How+To+Contribute (Running Tests)
      Hide
      Andrei Savu added a comment -

      The main advantage is that by using the same mechanism we can run the entire suite with a single command from the project root.

      Show
      Andrei Savu added a comment - The main advantage is that by using the same mechanism we can run the entire suite with a single command from the project root.
      Hide
      Andrei Savu added a comment -

      Ioannis do you have any local changes for this one? I can continue the work as needed.

      Show
      Andrei Savu added a comment - Ioannis do you have any local changes for this one? I can continue the work as needed.
      Hide
      Ioannis Canellos added a comment -

      I found this "forgotten" version of this patch on my disk.

      I think that it does apply the recommended changes, but currently I don't have the time to verify.

      Show
      Ioannis Canellos added a comment - I found this "forgotten" version of this patch on my disk. I think that it does apply the recommended changes, but currently I don't have the time to verify.
      Ioannis Canellos made changes -
      Attachment WHIRR-509-patch-2.txt [ 12516662 ]
      Hide
      Andrei Savu added a comment -

      Updated patch for latest trunk + cleanups. All tests are working and the ZooKeeper node is deployed as expected through Karaf.

      Please review! I think it should be ready to be committed.

      Show
      Andrei Savu added a comment - Updated patch for latest trunk + cleanups. All tests are working and the ZooKeeper node is deployed as expected through Karaf. Please review! I think it should be ready to be committed.
      Andrei Savu made changes -
      Attachment WHIRR-509.patch [ 12516674 ]
      Andrei Savu made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Assignee Ioannis Canellos [ iocanel ]
      Hide
      Ioannis Canellos added a comment -

      looks good to me!

      Show
      Ioannis Canellos added a comment - looks good to me!
      Hide
      Andrei Savu added a comment -

      Committed to trunk. Thanks Ioannis!

      Show
      Andrei Savu added a comment - Committed to trunk. Thanks Ioannis!
      Andrei Savu made changes -
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Tom White made changes -
      Fix Version/s 0.8.0 [ 12321649 ]
      Fix Version/s 0.8.0-alpha.1 [ 12318880 ]
      Tom White made changes -
      Affects Version/s 0.8.0 [ 12321649 ]
      Affects Version/s 0.8.0-alpha.1 [ 12318880 ]

        People

        • Assignee:
          Ioannis Canellos
          Reporter:
          Ioannis Canellos
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development