Whirr
  1. Whirr
  2. WHIRR-502

configure_cdh_hadoop.sh: syntax error trying to modify permissions on $HADOOP_LOG_DIR

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.7.1
    • Component/s: service/cdh
    • Labels:
      None

      Description

      This doesn't seem to cause any issues, AFAIK, but I noticed it while trying to customize the CDH hadoop configuration using whirr 0.7.0. The launch-cluster command included some output from the configuration scripts that I had been modifying, and I noticed this bit:

      chmod: missing operand after `/var/log/hadoop/logs'
      Try `chmod --help' for more information.
      

      Looks like this is caused by line 80 in services/cdh/src/main/resources/functions/configure_cdh_hadoop.sh:

      chmod -R $HADOOP_LOG_DIR
      

      Notice the missing permissions in the command. I assume this should be g+w, as in line 71? I checked the svn repo, and this looks like it affects the trunk, as well.

      1. WHIRR-502.patch
        0.6 kB
        Andrei Savu

        Activity

        Evan Pollan created issue -
        Hide
        Andrei Savu added a comment -

        Thanks for reporting! It may not be serious but it is something we need to fix.

        Show
        Andrei Savu added a comment - Thanks for reporting! It may not be serious but it is something we need to fix.
        Andrei Savu made changes -
        Field Original Value New Value
        Assignee Andrei Savu [ savu.andrei ]
        Fix Version/s 0.7.1 [ 12319462 ]
        Andrei Savu made changes -
        Fix Version/s 0.8.0 [ 12318880 ]
        Fix Version/s 0.7.1 [ 12319462 ]
        Andrei Savu made changes -
        Affects Version/s 0.7.1 [ 12319462 ]
        Andrei Savu made changes -
        Attachment WHIRR-502.patch [ 12513378 ]
        Andrei Savu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        David Alves added a comment -

        +1, trivial and applies cleanly

        Show
        David Alves added a comment - +1, trivial and applies cleanly
        Hide
        Andrei Savu added a comment -

        Committed to trunk! Thanks David.

        Show
        Andrei Savu added a comment - Committed to trunk! Thanks David.
        Andrei Savu made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Andrei Savu added a comment -

        Also committed to the 0.7 branch.

        Show
        Andrei Savu added a comment - Also committed to the 0.7 branch.
        Andrei Savu made changes -
        Fix Version/s 0.7.1 [ 12319942 ]
        Andrei Savu made changes -
        Fix Version/s 0.8.0 [ 12318880 ]
        Tom White made changes -
        Affects Version/s 0.8.0-alpha.1 [ 12318880 ]

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Evan Pollan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development