Whirr
  1. Whirr
  2. WHIRR-479

ScriptBasedClusterAction should allow filtering by role and instance-id

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:
      None

      Description

      Configure / Start / Stop / Cleanup are all based on ScriptBasedClusterAction. In order to make them even more useful we should be able to filter the nodes by role or by ID. E.g. ./bin/whirr stop-services --config ... --roles hadoop-datanode --instance-id us-east-1/i-231235

      1. WHIRR-479.patch
        32 kB
        Andrei Savu
      2. WHIRR-479.patch
        58 kB
        Andrei Savu
      3. WHIRR-479.patch
        108 kB
        Andrei Savu

        Issue Links

          Activity

          Hide
          Andrei Savu added a comment -

          First iteration on this one. I have done a bit of manual testing on aws-ec2 and everything seems to be working to be fine.

          I'm planning to add a bunch of dry run tests. Do you think that should be enough or do we also need integration tests?

          Show
          Andrei Savu added a comment - First iteration on this one. I have done a bit of manual testing on aws-ec2 and everything seems to be working to be fine. I'm planning to add a bunch of dry run tests. Do you think that should be enough or do we also need integration tests?
          Hide
          Andrei Savu added a comment -

          I have attached an updated version that also includes a bunch of error handling improvements. Next: going to add tests & it should be ready for review.

          Show
          Andrei Savu added a comment - I have attached an updated version that also includes a bunch of error handling improvements. Next: going to add tests & it should be ready for review.
          Hide
          Andrei Savu added a comment -

          Added a comprehensive set of tests for service lifecycle actions + a bunch of cleanups & refactoring. Please review!

          Show
          Andrei Savu added a comment - Added a comprehensive set of tests for service lifecycle actions + a bunch of cleanups & refactoring. Please review!
          Hide
          Andrei Savu added a comment -

          All unit tests + zookeeper integration tests on aws-ec2 pass as expected.

          Show
          Andrei Savu added a comment - All unit tests + zookeeper integration tests on aws-ec2 pass as expected.
          Hide
          Andrei Savu added a comment -

          Let me know if something looks strange.

          Show
          Andrei Savu added a comment - Let me know if something looks strange.
          Hide
          Andrei Savu added a comment -
          Show
          Andrei Savu added a comment - Same diff on Github: https://github.com/andreisavu/whirr/compare/trunk...whirr-479
          Hide
          Andrei Savu added a comment -

          Committed to trunk. Thanks Lars for reviewing (+1 on the email list).

          Show
          Andrei Savu added a comment - Committed to trunk. Thanks Lars for reviewing (+1 on the email list).

            People

            • Assignee:
              Andrei Savu
              Reporter:
              Andrei Savu
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development