Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: core
    • Labels:
      None

      Description

      We need a uniform way of creating Service instances by name, for the CLI (WHIRR-33), for example.

      1. WHIRR-47.patch
        10 kB
        Tom White
      2. WHIRR-47.patch
        9 kB
        Tom White

        Issue Links

          Activity

          Hide
          Tom White added a comment -

          This patch introduces a SPI, modelled along the lines of one described at http://weblogs.java.net/blog/2006/04/07/creating-service-provider-interface.

          Show
          Tom White added a comment - This patch introduces a SPI, modelled along the lines of one described at http://weblogs.java.net/blog/2006/04/07/creating-service-provider-interface .
          Hide
          Patrick Hunt added a comment -

          lgtm, some issues:

          1) good practice to have javadoc for main/test class/methods

          2) service factory constructor needs to log something on error (currently just ignores)

          Show
          Patrick Hunt added a comment - lgtm, some issues: 1) good practice to have javadoc for main/test class/methods 2) service factory constructor needs to log something on error (currently just ignores)
          Hide
          Tom White added a comment -

          Here's a new patch which addresses Patrick's feedback.

          Show
          Tom White added a comment - Here's a new patch which addresses Patrick's feedback.
          Hide
          Tom White added a comment -

          I've just committed this.

          Show
          Tom White added a comment - I've just committed this.

            People

            • Assignee:
              Tom White
              Reporter:
              Tom White
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development