Whirr
  1. Whirr
  2. WHIRR-447

FastDnsResolver fails with SocketTimeoutException

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      FastDnsResolver should not fail with SocketTimeoutException but instead it should return the IP address (same behaviour as standard Java).

      1. WHIRR-447.patch
        13 kB
        Andrei Savu
      2. WHIRR-447.patch
        12 kB
        Andrei Savu

        Issue Links

          Activity

          Hide
          Andrei Savu added a comment -

          Committed. Thanks Adrian for review!

          Show
          Andrei Savu added a comment - Committed. Thanks Adrian for review!
          Hide
          Adrian Cole added a comment -

          +1 looks alright to me. applies clean, tests pass.

          Show
          Adrian Cole added a comment - +1 looks alright to me. applies clean, tests pass.
          Hide
          Andrei Savu added a comment -

          It should be good to go now.

          Show
          Andrei Savu added a comment - It should be good to go now.
          Hide
          Andrei Savu added a comment -

          Fixed broken patch.

          Show
          Andrei Savu added a comment - Fixed broken patch.
          Hide
          Andrei Savu added a comment -

          In this patch:

          • upgraded dnsjava to 2.1.1
          • code cleanup
          • switched from UPD to TCP (it seems like this was the root problem affecting me)
          Show
          Andrei Savu added a comment - In this patch: upgraded dnsjava to 2.1.1 code cleanup switched from UPD to TCP (it seems like this was the root problem affecting me)

            People

            • Assignee:
              Andrei Savu
              Reporter:
              Andrei Savu
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development