Whirr
  1. Whirr
  2. WHIRR-442

release 0.6.0 is in breach of the AL2.0 and general Apache rules in regards to the inclusion of Voldemort

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.6.0
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Release 0.6.0 is including the Voldemort jar w/o the required notices as specified by section 4d of the ASL2.0
      https://github.com/voldemort/voldemort/blob/master/LICENSE

      Additionally Voldemort requires a "category X" licensed work which is not allowed by Apache rules, specifically Voldemort uses "BDB java edition" which is category X. See previous discussions on this:
      https://issues.apache.org/jira/browse/LEGAL-99
      https://issues.apache.org/jira/browse/LEGAL-113
      http://www.apache.org/legal/resolved.html

      The following has to happen before 0.7.0:

      1) remove all jars from the source release artifact.

      ./services/voldemort/lib/linkedin-voldemort-0.90.RC3.jar

      I also notice:
      ./services/hadoop/lib/hadoop-test-0.20.3-SNAPSHOT.jar
      ./services/cassandra/lib/apache-cassandra-0.7.0.jar
      ./services/cassandra/lib/libthrift-0.5.jar

      2) do not compile or include dependencies of Voldemort as part of any Whirr release, whether source or binary. I do not think that the Voldemort whirr service itself need be dropped.

        Activity

        Hide
        Andrei Savu added a comment -

        I have committed the trivial change to ignore the voldemort .jar when building the binary release.

        Show
        Andrei Savu added a comment - I have committed the trivial change to ignore the voldemort .jar when building the binary release.
        Hide
        Andrei Savu added a comment -

        A quick patch that removes the Voldemort .jar from the bin release.

        Show
        Andrei Savu added a comment - A quick patch that removes the Voldemort .jar from the bin release.
        Hide
        Andrei Savu added a comment -

        Committed to trunk. Thanks Tom!

        Show
        Andrei Savu added a comment - Committed to trunk. Thanks Tom!
        Hide
        Andrei Savu added a comment - - edited

        +1

        I had to add the following line to pom.xml (RAT config):

        <exclude>**/*.iml </exclude> <!-- IDEA project files -->

        Later on we should also update the How to Release / How to Contribute wiki pages to mention -Pvoldemort.

        Show
        Andrei Savu added a comment - - edited +1 I had to add the following line to pom.xml (RAT config): <exclude>**/*.iml </exclude> <!-- IDEA project files --> Later on we should also update the How to Release / How to Contribute wiki pages to mention -Pvoldemort.
        Hide
        Tom White added a comment -

        This patch should satisfy 1) and 2) above.

        It removes all the JARs from svn (and the source artifact). Cassandra is now in Maven, so there is no need to include the JARs. The Hadoop test JAR from the latest 0.20 release (0.20.205.0) includes the test class that was the reason a JAR was checked in before, so I upgraded to that version.

        For Voldermort, there are no JARs in Maven, so to build it you need to download the JAR manually and place it in the services/voldemort/lib directory. Also, to satisfy 2), it is not built by default, but only when the "voldemort" profile is activated (by -Pvoldemort).

        After applying the patch, also run

        svn rm ./services/cassandra/lib
        svn rm ./services/hadoop/lib
        svn rm ./services/voldemort/lib/linkedin-voldemort-0.90.RC3.jar
        svn propset svn:ignore 'linkedin-voldemort-0.90.RC3.jar' ./services/voldemort/lib/
        
        Show
        Tom White added a comment - This patch should satisfy 1) and 2) above. It removes all the JARs from svn (and the source artifact). Cassandra is now in Maven, so there is no need to include the JARs. The Hadoop test JAR from the latest 0.20 release (0.20.205.0) includes the test class that was the reason a JAR was checked in before, so I upgraded to that version. For Voldermort, there are no JARs in Maven, so to build it you need to download the JAR manually and place it in the services/voldemort/lib directory. Also, to satisfy 2), it is not built by default, but only when the "voldemort" profile is activated (by -Pvoldemort). After applying the patch, also run svn rm ./services/cassandra/lib svn rm ./services/hadoop/lib svn rm ./services/voldemort/lib/linkedin-voldemort-0.90.RC3.jar svn propset svn:ignore 'linkedin-voldemort-0.90.RC3.jar' ./services/voldemort/lib/

          People

          • Assignee:
            Tom White
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development