Whirr
  1. Whirr
  2. WHIRR-440

Unit tests improvements (less bound to external services)

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      In this patch I have made the unit tests less dependent on having the ability to perform reverse DNS
      resolution and I have also switched some tests to use a memory based state store. We should set a
      goal for 0.8.0 to be able to run the unit tests without having an internet connection.

      1. WHIRR-440.patch
        65 kB
        Andrei Savu
      2. WHIRR-440.patch
        74 kB
        Andrei Savu

        Activity

        Andrei Savu created issue -
        Hide
        Andrei Savu added a comment -

        Please review.

        Show
        Andrei Savu added a comment - Please review.
        Andrei Savu made changes -
        Field Original Value New Value
        Attachment WHIRR-440.patch [ 12506067 ]
        Andrei Savu made changes -
        Fix Version/s 0.7.0 [ 12317571 ]
        Fix Version/s 0.8.0 [ 12318880 ]
        Hide
        Tom White added a comment -

        +1

        There's a checkstyle warning in FastDnsResolver. After I fixed that all the unit tests passed for me.

        Also, how about changing o.a.whirr.service.state to o.a.whirr.state, and o.a.whirr.util.dns to o.a.whirr.net?

        Show
        Tom White added a comment - +1 There's a checkstyle warning in FastDnsResolver. After I fixed that all the unit tests passed for me. Also, how about changing o.a.whirr.service.state to o.a.whirr.state, and o.a.whirr.util.dns to o.a.whirr.net?
        Hide
        Andrei Savu added a comment -

        Here is an updated version of the patch - changed package names and fixed checkstyle. I'm going to commit this now.

        Show
        Andrei Savu added a comment - Here is an updated version of the patch - changed package names and fixed checkstyle. I'm going to commit this now.
        Andrei Savu made changes -
        Attachment WHIRR-440.patch [ 12506486 ]
        Hide
        Andrei Savu added a comment -

        Committed to trunk. Thanks Tom for reviewing.

        Show
        Andrei Savu added a comment - Committed to trunk. Thanks Tom for reviewing.
        Andrei Savu made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        2d 17h 57m 1 Andrei Savu 07/Dec/11 17:16

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Andrei Savu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development