Details
-
Type:
Improvement
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 0.6.0
-
Fix Version/s: 0.7.0
-
Component/s: None
-
Labels:None
Description
Currently, we add jclouds modules in a hard-coded way. This implies that the patches to jclouds, which ssh driver we use, etc. cannot be changed without a code release or patching Whirr. jclouds has a property: "jclouds.modules" which when specified overrides the wiring that we would use.
I believe that except in the case of dry run, we need the following property so that we can stop hard-coding the list:
jclouds.modules=org.jclouds.logging.slf4j.config.SLF4JLoggingModule,org.jclouds.enterprise.config.EnterpriseConfigurationModule,org.jclouds.sshj.config.SshjSshClientModule,org.apache.whirr.service.jclouds.BindLoginCredentialsPatchForEC2
With this in place, people can feel free to use jsch or sshj, for example, and also remove or update patches we make to jclouds.
Activity
if you'd like to try this wrt changing modules, add the jclouds maven dependency org.jclouds.driver/jclouds-jsch and set the following:
jclouds.modules=org.jclouds.logging.slf4j.config.SLF4JLoggingModule,org.jclouds.enterprise.config.EnterpriseConfigurationModule,org.jclouds.ssh.jsch.config.JschSshClientModule,org.apache.whirr.service.jclouds.BindLoginCredentialsPatchForEC2
tested several times with cloudservers-uk (as I'm testing from brussels)
+1 tested on aws-ec2 using the hbase integration tests (fixed a typo)
Commited. Thanks Adrian!
This patch allows people to change to jsch if they like