Apache Whirr (retired)
  1. Apache Whirr (retired)
  2. WHIRR-409

Add an integration test that shows that there is no overlap between install & configure scripts on the remote machine

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: core
    • Labels:
      None

      Description

      We had some doubts about this fact in the past. We already have a test, added as part of the DryRunModule, that shows that the phase execution barrier is enforced on the client. This new test is designed to show that the barrier is also enforced on the remote machine by jclouds (remote script execution tracking).

      1. WHIRR-409.patch
        11 kB
        Andrei Savu
      2. WHIRR-409.patch
        11 kB
        Andrei Savu
      3. WHIRR-409.patch
        11 kB
        Andrei Savu
      4. WHIRR-409.patch
        8 kB
        Andrei Savu

        Activity

        Hide
        Alex Heneveld added a comment -

        very handy test. looks good to me, and passes fine.

        might want to have a sleep in configure and another date printed to ensure barrier between configure and launch-cluster complete is enforced. (i tried this and it behaves.)

        Show
        Alex Heneveld added a comment - very handy test. looks good to me, and passes fine. might want to have a sleep in configure and another date printed to ensure barrier between configure and launch-cluster complete is enforced. (i tried this and it behaves.)
        Hide
        Andrei Savu added a comment -

        Thanks Alex for trying the test. I will improve it later this week to also cover that scenario.

        Show
        Andrei Savu added a comment - Thanks Alex for trying the test. I will improve it later this week to also cover that scenario.
        Hide
        Andrei Savu added a comment -

        Updated integration test to also check the timing on the local machine for all events. I will not add an integration test for beforeDestroy script execution because we are already testing that code path with beforeConfigure and everything should be fine + we have an unit test.

        Show
        Andrei Savu added a comment - Updated integration test to also check the timing on the local machine for all events. I will not add an integration test for beforeDestroy script execution because we are already testing that code path with beforeConfigure and everything should be fine + we have an unit test.
        Hide
        Andrei Savu added a comment -

        Updated cluster name to match WHIRR-426. Please review!

        Show
        Andrei Savu added a comment - Updated cluster name to match WHIRR-426 . Please review!
        Hide
        David Alves added a comment -

        Applies cleanly, but no go due to checkstyle (unused imports on the new test).
        Builds cleanly when fixed, and as it had already been itested: +1.

        Show
        David Alves added a comment - Applies cleanly, but no go due to checkstyle (unused imports on the new test). Builds cleanly when fixed, and as it had already been itested: +1.
        Hide
        Andrei Savu added a comment -

        Updated patch to make checkstyle happy.

        Show
        Andrei Savu added a comment - Updated patch to make checkstyle happy.
        Hide
        Andrei Savu added a comment -

        Committed. Thanks David for reviewing.

        Show
        Andrei Savu added a comment - Committed. Thanks David for reviewing.

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Andrei Savu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development