[WHIRR-394] NPE used for flow control

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.7.0
• Component/s: core
• Assignee: David Alves
• Reporter: David Alves
• Created: 07/Oct/11 15:43
• Updated: 14/Oct/11 15:30
• Resolved: 14/Oct/11 15:30

Description

ScriptBasedClusterAction is using NPE for flow control.

public Cluster execute(ClusterSpec clusterSpec, Cluster cluster) throws IOException, InterruptedException {
...
for (String role : instanceTemplate.getRoles()) {
try

{ handlerMap.get(role).beforeAction(event); }

catch (NullPointerException e)

{ throw new IllegalArgumentException("No handler for role " + role); }

}
...
}

I just lost about an hour trying to find out why the actionhandler was not being registered while the NPE came from the beforeAction() call.