Whirr
  1. Whirr
  2. WHIRR-376

Launching a BYON cluster doesn't produce an instances file.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      whirr launch-cluster doesn't produce an instances file when running a byon cluster.
      By consequence, whirr run-script and whirr list-cluster doesn't work for byon clusters.

      This isn't a bit problem for testing, but when installing to private hosted nodes it may be more annoying.

      1. WHIRR-376.patch
        3 kB
        Karel Vervaeke
      2. WHIRR-376.patch
        9 kB
        Karel Vervaeke

        Activity

        Hide
        Karel Vervaeke added a comment -

        Attached rough patch. Changes:

        • make launch-cluster write out an instances file
        • make launch-list-cluster work (sort of) Limitations:
        • it list all nodes from the yaml file as RUNNING. That's probably related to the way the byon provider works)
        • whirr.cluster-name MUST match be set to match 'group' property used in the yaml file: see ByonClusterController.getNodes(...)
        • whirr run-script doesn't work yet. It tries to connect using my actual user name (whirr.identity is ignored, but it doesn't use the 'user' property from the yaml file either)
        Show
        Karel Vervaeke added a comment - Attached rough patch. Changes: make launch-cluster write out an instances file make launch-list-cluster work (sort of) Limitations: it list all nodes from the yaml file as RUNNING. That's probably related to the way the byon provider works) whirr.cluster-name MUST match be set to match 'group' property used in the yaml file: see ByonClusterController.getNodes(...) whirr run-script doesn't work yet. It tries to connect using my actual user name (whirr.identity is ignored, but it doesn't use the 'user' property from the yaml file either)
        Hide
        Adrian Cole (Inactive) added a comment -

        Hi, Karel.

        Here's a couple hints that can help on this:
        https://github.com/jclouds/jclouds/tree/master/apis/byon (the property is username not user)

        https://github.com/jclouds/jclouds/blob/master/apis/byon/src/test/java/org/jclouds/byon/BYONComputeServiceLiveTest.java (example of running scripts)

        Show
        Adrian Cole (Inactive) added a comment - Hi, Karel. Here's a couple hints that can help on this: https://github.com/jclouds/jclouds/tree/master/apis/byon (the property is username not user) https://github.com/jclouds/jclouds/blob/master/apis/byon/src/test/java/org/jclouds/byon/BYONComputeServiceLiveTest.java (example of running scripts)
        Hide
        Karel Vervaeke added a comment -

        Got run-script working.
        Only remaining issue is that all nodes in the BYON yaml file appear as RUNNING during list-cluster (rather than only the nodes that were actually used during launch-cluster).

        I'd like to commit this in it's current state (plus changelog entry) since it's already a nice improvement (IMO). The remaining issue can get a new (low-priority ) Jira entry.

        Show
        Karel Vervaeke added a comment - Got run-script working. Only remaining issue is that all nodes in the BYON yaml file appear as RUNNING during list-cluster (rather than only the nodes that were actually used during launch-cluster). I'd like to commit this in it's current state (plus changelog entry) since it's already a nice improvement (IMO). The remaining issue can get a new (low-priority ) Jira entry.
        Hide
        Andrei Savu added a comment -

        +1 the code looks good. I haven't tried to run it because I don't have a local vagrant / virtualbox setup now.

        Nit: You should probably revert the changes made to recipes/nodes-byon.yaml before committing

        Show
        Andrei Savu added a comment - +1 the code looks good. I haven't tried to run it because I don't have a local vagrant / virtualbox setup now. Nit: You should probably revert the changes made to recipes/nodes-byon.yaml before committing
        Hide
        Karel Vervaeke added a comment -

        grr, I don't know how I always manage to include the yaml file in my patches.

        Show
        Karel Vervaeke added a comment - grr, I don't know how I always manage to include the yaml file in my patches.
        Hide
        Karel Vervaeke added a comment -

        Committed in r1178800

        Show
        Karel Vervaeke added a comment - Committed in r1178800

          People

          • Assignee:
            Karel Vervaeke
            Reporter:
            Karel Vervaeke
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development