Please figure out a way to get the attached ConfigureClusterAction passing checkstyle, as it took a while to refine, but maven isn't telling me what is wrong with it.
ok. logic is failing at the following redundant check:
// Check it's the correct cluster
we are already know it is in the cluster from the latter check on id (taken from cluster map), so the above code is redundant.
For some reason in aws-ec2, the security group name isn't parsing properly which is why that check is failing. I'd recommend applying the attached version of ConfigureClusterAction, taking out the redundant cluster name check so that aws-ec2 can work without a patch on jclouds.
I've verified the solution I'm recommending works, but please do re-check. Also note, I am using the patch in
WHIRR-341 so that I'm testing against a stable ubuntu ami.