Apache Whirr (retired)
  1. Apache Whirr (retired)
  2. WHIRR-266 Separate tasks of both install and configuration scripts into more generic and detailed functions
  3. WHIRR-297

Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions

        Details

          Description

          Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.

          We should have something like:

          {start,stop,install,configure,cleanup}_zookeeper{start,stop,install,configure,cleanup}

          _elasticsearch

          Naming consistency would be helpful.

          1. Text File
            WHIRR-297.patch
            19 kB
            Andrei Savu
          2. Text File
            WHIRR-297.patch
            19 kB
            Andrei Savu

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Andrei Savu added a comment -

            Resubmitting the patch to this sub-task so that we can commit and close if it looks ok. Integration tests pass on EC2.

            Show
            Andrei Savu added a comment - Resubmitting the patch to this sub-task so that we can commit and close if it looks ok. Integration tests pass on EC2.
            Hide
            Permalink
            Tom White added a comment -

            +1 Looks good, with one caveat. I would rather ScriptBasedClusterAction didn't install any scripts by default, since they may not be needed by all services, and they bulk up the aggregated scripts that are transferred over SSH to each node. Also, in a Puppet or Chef world, they would be unused, I think.

            Would it be reasonable to have action handlers do the registration? (I'm thinking that we could shorten the syntax so you can register more than one script in one go: e.g. addStatements(event, allOf("install_java", "install_service", "remove_service")); - this could go in a future JIRA, if needed.)

            Show
            Tom White added a comment - +1 Looks good, with one caveat. I would rather ScriptBasedClusterAction didn't install any scripts by default, since they may not be needed by all services, and they bulk up the aggregated scripts that are transferred over SSH to each node. Also, in a Puppet or Chef world, they would be unused, I think. Would it be reasonable to have action handlers do the registration? (I'm thinking that we could shorten the syntax so you can register more than one script in one go: e.g. addStatements(event, allOf("install_java", "install_service", "remove_service")); - this could go in a future JIRA, if needed.)
            Hide
            Permalink
            Andrei Savu added a comment -

            Removed code from ScriptBasedClusterAction. I'm going to commit this. We can do more refactoring in new patches.

            Show
            Andrei Savu added a comment - Removed code from ScriptBasedClusterAction. I'm going to commit this. We can do more refactoring in new patches.
            Hide
            Permalink
            Andrei Savu added a comment -

            I've just committed this. Thanks Tom for reviewing.

            Show
            Andrei Savu added a comment - I've just committed this. Thanks Tom for reviewing.

              People

              • Assignee:
                Andrei Savu
                Reporter:
                Andrei Savu
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development