Whirr
  1. Whirr
  2. WHIRR-289

Display role names in list-cluster command

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: None
    • Labels:
      None

      Description

      List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine.

      1. WHIRR-289.patch
        12 kB
        Andrei Savu
      2. WHIRR-289.patch
        8 kB
        Andrei Savu

        Issue Links

          Activity

          Hide
          Andrei Savu added a comment -

          Trivial patch tested on ec2.

          Show
          Andrei Savu added a comment - Trivial patch tested on ec2.
          Hide
          Tom White added a comment -

          How about changing ClusterController.getNodes() to return Cluster.Instance objects? It shouldn't really be returning NodeMetadata in the public interface anyway, and making this change would help other callers of the interface (so they can find roles), not just the CLI.

          Show
          Tom White added a comment - How about changing ClusterController.getNodes() to return Cluster.Instance objects? It shouldn't really be returning NodeMetadata in the public interface anyway, and making this change would help other callers of the interface (so they can find roles), not just the CLI.
          Hide
          Tom White added a comment -

          We could do this by adding a getInstances() method and deprecating getNodes().

          Show
          Tom White added a comment - We could do this by adding a getInstances() method and deprecating getNodes().
          Hide
          Andrei Savu added a comment -

          Great idea! I will update the code.

          Show
          Andrei Savu added a comment - Great idea! I will update the code.
          Hide
          Andrei Savu added a comment -

          Updated patch. Tom, let me know what you think.

          Show
          Andrei Savu added a comment - Updated patch. Tom, let me know what you think.
          Hide
          Tom White added a comment -

          +1

          Show
          Tom White added a comment - +1
          Hide
          Andrei Savu added a comment -

          I've just committed this. Tom, thanks for taking the time to review.

          Show
          Andrei Savu added a comment - I've just committed this. Tom, thanks for taking the time to review.

            People

            • Assignee:
              Andrei Savu
              Reporter:
              Andrei Savu
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development