Uploaded image for project: 'Apache Whirr (retired)'
  1. Apache Whirr (retired)
  2. WHIRR-278

Refactor ClusterSpec and extract InstanceTemplate class

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.5.0
        • Component/s: None
        • Labels:
          None

          Description

          The file containing the ClusterSpec class is getting to large. I suggest we should refactor the code to remove duplication and extract the InstanceTemplate class. I also think it's a good idea to remove code that was deprecated in 0.4.0.

          1. Text File
            WHIRR-278.patch
            34 kB
            Andrei Savu

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tomwhite Tom White added a comment -

            This is a good change. Is it worth extracting Instance from Cluster for symmetry at the same time?

            This will clash with WHIRR-245 (which I've just created a patch for), so we should think about staging them. How easy is it to regenerate this post-WHIRR-245?

            Show
            tomwhite Tom White added a comment - This is a good change. Is it worth extracting Instance from Cluster for symmetry at the same time? This will clash with WHIRR-245 (which I've just created a patch for), so we should think about staging them. How easy is it to regenerate this post- WHIRR-245 ?
            Hide
            Permalink
            savu.andrei Andrei Savu added a comment -

            > Is it worth extracting Instance from Cluster for symmetry at the same time?

            Cluster.Instance is not that large and overall the Cluster class is small. I would postpone this change.

            It would be great if we could commit this before WHIRR-245 because I want to add new options to ClusterSpec useful when creating the BlobStoreContext.

            I can commit the patch now if it looks ready to you.

            Show
            savu.andrei Andrei Savu added a comment - > Is it worth extracting Instance from Cluster for symmetry at the same time? Cluster.Instance is not that large and overall the Cluster class is small. I would postpone this change. It would be great if we could commit this before WHIRR-245 because I want to add new options to ClusterSpec useful when creating the BlobStoreContext. I can commit the patch now if it looks ready to you.
            Hide
            Permalink
            tomwhite Tom White added a comment -

            +1

            Show
            tomwhite Tom White added a comment - +1
            Hide
            Permalink
            savu.andrei Andrei Savu added a comment -

            I've just committed this. Thanks Tom for review!

            Show
            savu.andrei Andrei Savu added a comment - I've just committed this. Thanks Tom for review!

              People

              • Assignee:
                savu.andrei Andrei Savu
                Reporter:
                savu.andrei Andrei Savu
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development