Whirr
  1. Whirr
  2. WHIRR-259

Disable configuration list handling for Hadoop properties

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.

        Activity

        Andrei Savu created issue -
        Hide
        Andrei Savu added a comment -

        This patch joins the lists using the default delimiter for hadoop specific configuration options. It's not possible to completely disable list handling (e.g. whirr.instance-templates).

        Show
        Andrei Savu added a comment - This patch joins the lists using the default delimiter for hadoop specific configuration options. It's not possible to completely disable list handling (e.g. whirr.instance-templates).
        Andrei Savu made changes -
        Field Original Value New Value
        Attachment WHIRR-259.patch [ 12473477 ]
        Hide
        Tom White added a comment -

        I wonder why list escaping doesn't work - ideally we would get this working so we stick to the contract of http://commons.apache.org/configuration/howto_properties.html. But if there's a bug there then this workaround seems OK.

        Show
        Tom White added a comment - I wonder why list escaping doesn't work - ideally we would get this working so we stick to the contract of http://commons.apache.org/configuration/howto_properties.html . But if there's a bug there then this workaround seems OK.
        Hide
        Tom White added a comment -

        Another way of doing this would be to call setDelimiterParsingDisabled(true), according to http://commons.apache.org/configuration/howto_basicfeatures.html#List_handling. However, we only want to do this for the Hadoop configuration, since we use lists for instance templates.

        Show
        Tom White added a comment - Another way of doing this would be to call setDelimiterParsingDisabled(true), according to http://commons.apache.org/configuration/howto_basicfeatures.html#List_handling . However, we only want to do this for the Hadoop configuration, since we use lists for instance templates.
        Hide
        Andrei Savu added a comment -

        Tom, I've tried that approach. It would be great if common-configuration would provide a way of retrieving the original property value (before splitting).

        Show
        Andrei Savu added a comment - Tom, I've tried that approach. It would be great if common-configuration would provide a way of retrieving the original property value (before splitting).
        Hide
        Tom White added a comment -

        I can't see another way of doing this either. +1 to the patch.

        Show
        Tom White added a comment - I can't see another way of doing this either. +1 to the patch.
        Andrei Savu made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Andrei Savu added a comment -

        I've just committed this. Thanks Tom for reviewing.

        Show
        Andrei Savu added a comment - I've just committed this. Thanks Tom for reviewing.
        Andrei Savu made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Andrei Savu [ savu.andrei ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Andrei Savu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development