Whirr
  1. Whirr
  2. WHIRR-226

Add the ability to destroy a cluster instance

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: cli, core
    • Labels:
      None

      Description

      For testing purpose it would be nice if the the user could destroy a specific or a random cluster instance.

      1. WHIRR-226.patch
        10 kB
        Andrei Savu
      2. WHIRR-226.patch
        11 kB
        Andrei Savu
      3. WHIRR-226.patch
        7 kB
        Andrei Savu

        Activity

        Hide
        Andrei Savu added a comment -

        Let me know what you think.

        Show
        Andrei Savu added a comment - Let me know what you think.
        Hide
        Tom White added a comment -

        Do you need to expose the 'random' feature in the CLI? Can the test not choose this itself?

        Please add a unit test for DestroyInstanceCommand.

        Show
        Tom White added a comment - Do you need to expose the 'random' feature in the CLI? Can the test not choose this itself? Please add a unit test for DestroyInstanceCommand.
        Hide
        Andrei Savu added a comment -

        > Do you need to expose the 'random' feature in the CLI?

        Not really. It makes sense for services like ZooKeeper but for services like HDFS killing the namenode will bring down the whole cluster so it's not that useful. I now realize that it needs to be aware of the instance role.

        I will submit an updated version of the patch soon (+ unit tests).

        Show
        Andrei Savu added a comment - > Do you need to expose the 'random' feature in the CLI? Not really. It makes sense for services like ZooKeeper but for services like HDFS killing the namenode will bring down the whole cluster so it's not that useful. I now realize that it needs to be aware of the instance role. I will submit an updated version of the patch soon (+ unit tests).
        Hide
        Andrei Savu added a comment -

        I have updated the patch and added basic unit tests.

        Show
        Andrei Savu added a comment - I have updated the patch and added basic unit tests.
        Hide
        Tom White added a comment -

        Looks good. Thanks for adding the test. Looks like there are some spurious imports in DestroyInstanceCommand - e.g. Random. And some imports re-arranged in Service that don't need to be.

        Show
        Tom White added a comment - Looks good. Thanks for adding the test. Looks like there are some spurious imports in DestroyInstanceCommand - e.g. Random. And some imports re-arranged in Service that don't need to be.
        Hide
        Andrei Savu added a comment -

        I have updated the patch. Tom, thanks for reviewing.

        Show
        Andrei Savu added a comment - I have updated the patch. Tom, thanks for reviewing.
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Andrei Savu added a comment -

        I've just committed this. Thanks Tom.

        Show
        Andrei Savu added a comment - I've just committed this. Thanks Tom.

          People

          • Assignee:
            Andrei Savu
            Reporter:
            Andrei Savu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development