Whirr
  1. Whirr
  2. WHIRR-219

Support dynamic addition of services to CLI

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: cli
    • Labels:
      None

      Description

      Currently the CLI only supports services that it was compiled with. To allow service jars to be added later, we should relax this limitation.

        Activity

        Hide
        Tom White added a comment -

        This patch removes the shade plugin, and changes the bin/whirr script to use a wildcard to pick up all the jars in lib. This makes it straightforward to add new services (by dropping jars into lib). I tested this by building a binary distribution and starting a zookeeper cluster.

        Show
        Tom White added a comment - This patch removes the shade plugin, and changes the bin/whirr script to use a wildcard to pick up all the jars in lib. This makes it straightforward to add new services (by dropping jars into lib). I tested this by building a binary distribution and starting a zookeeper cluster.
        Hide
        Andrei Savu added a comment -

        +1 I like this approach. I've done some testing and it seems like the patch works as expected.

        Show
        Andrei Savu added a comment - +1 I like this approach. I've done some testing and it seems like the patch works as expected.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks for the review Andrei.

        Show
        Tom White added a comment - I've just committed this. Thanks for the review Andrei.

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development