Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: None
    • Labels:
      None

      Description

      We should use checkstyle to enforce the Java style guidelines. See http://maven.apache.org/plugins/maven-checkstyle-plugin/usage.html.

      I suggest these should be same as Hadoop's (Sun's conventions except 2 spaces for tabs, http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html).

        Activity

        Hide
        Tom White added a comment -

        This patch adds checkstyle checks (use mvn checkstyle:checkstyle to run) and fixes existing problems. Adds a build-tools module following the recommendation at http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html.

        Since this makes lots of whitespace changes (to fix errant tabs) I'm going to check it in soon.

        Show
        Tom White added a comment - This patch adds checkstyle checks (use mvn checkstyle:checkstyle to run) and fixes existing problems. Adds a build-tools module following the recommendation at http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html . Since this makes lots of whitespace changes (to fix errant tabs) I'm going to check it in soon.
        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development