Whirr
  1. Whirr
  2. WHIRR-172

Log warning for unrecognized service names

        Details

        • Type: Bug Bug
        • Status: Resolved
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.5.0
        • Component/s: None
        • Labels:
          None

          Description

          We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Lars George added a comment - - edited

            The error was:

            $ bin/whirr launch-cluster --config hbase-cluster.properties
Unable to find service hbase, exiting
Usage: whirr launch-cluster [OPTIONS]
 
Option                                  Description                            
------                                  -----------                            
--client-cidrs                                                                
--cluster-name                                                                
--config                                                                      
--credential                                                                  
--hardware-id                                                                  
--identity                                                                    
--image-id                                                                    
--instance-templates                                                          
--location-id                                                                  
--private-key-file                                                            
--provider                                                                    
--public-key-file                                                              
--run-url-base                                                                
--service-name                                                                
--version

            I also suggest to add "(deprecated)" next to "--service-name" to be safe. And obviously the docs need to be adjusted, at the very latest when this option is dropped.

            Show
            Lars George added a comment - - edited The error was: $ bin/whirr launch-cluster --config hbase-cluster.properties Unable to find service hbase, exiting Usage: whirr launch-cluster [OPTIONS] Option Description ------ ----------- --client-cidrs --cluster-name --config --credential --hardware-id --identity --image-id --instance-templates --location-id -- private -key-file --provider -- public -key-file --run-url-base --service-name --version I also suggest to add "(deprecated)" next to "--service-name" to be safe. And obviously the docs need to be adjusted, at the very latest when this option is dropped.
            Hide
            Permalink
            Andrei Savu added a comment -

            I suggest that we should not change the current behavior because "--service-name" is optional (not deprecated) and if the user specifies an invalid value that should be treated like a fatal error. I have also fixed the docs in WHIRR-181

            Show
            Andrei Savu added a comment - I suggest that we should not change the current behavior because "--service-name" is optional (not deprecated) and if the user specifies an invalid value that should be treated like a fatal error. I have also fixed the docs in WHIRR-181
            Hide
            Permalink
            Tom White added a comment -

            I don't think this is a blocker for 0.3.0.

            Show
            Tom White added a comment - I don't think this is a blocker for 0.3.0.
            Hide
            Permalink
            Tom White added a comment -

            This caught me out as I have a properties file with "whirr.service-name=hadoop" in it, and since WHIRR-245 there are no longer service subclasses for Hadoop, Cassandra, and ZooKeeper.

            This patch simply falls back to the default ClusterController, if the named one can't be loaded (after logging a warning).

            Show
            Tom White added a comment - This caught me out as I have a properties file with "whirr.service-name=hadoop" in it, and since WHIRR-245 there are no longer service subclasses for Hadoop, Cassandra, and ZooKeeper. This patch simply falls back to the default ClusterController, if the named one can't be loaded (after logging a warning).
            Hide
            Permalink
            Andrei Savu added a comment -

            +1 before committing you should remove the star import from tests.

            Show
            Andrei Savu added a comment - +1 before committing you should remove the star import from tests.
            Hide
            Permalink
            Tom White added a comment -

            I've just committed this. Thanks for the review Andrei - I fixed the star import.

            Show
            Tom White added a comment - I've just committed this. Thanks for the review Andrei - I fixed the star import.

              People

              • Assignee:
                Tom White
                Reporter:
                Tom White
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development