Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.3.0
    • Component/s: core
    • Labels:
      None

      Description

      From WHIRR-117 a cluster may run multiple services, making the service-name property redundant, since the role names in the instance template drive the bootstrapping and configuration of nodes.

      We should remove it, or at least make it optional, since there may still be a need for different implementations of Service (e.g. WHIRR-125).

        Activity

        Hide
        Tom White added a comment -

        Here's a straightforward patch which makes the service name optional. It passes tests.

        Show
        Tom White added a comment - Here's a straightforward patch which makes the service name optional. It passes tests.
        Hide
        Andrei Savu added a comment - - edited

        +1 Looks good. All unit tests are passing for me (& zookeeper integration tests on ec2).

        Show
        Andrei Savu added a comment - - edited +1 Looks good. All unit tests are passing for me (& zookeeper integration tests on ec2).
        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development