Whirr
  1. Whirr
  2. WHIRR-109

Unit tests fail if there is no private key found at ~/.ssh/id_rsa

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2.0
    • Component/s: None
    • Labels:
      None

      Description

      We should generate a key for the test.

      1. WHIRR-109.patch
        11 kB
        Adrian Cole
      2. WHIRR-109.patch
        13 kB
        Adrian Cole

        Activity

        Hide
        Tom White added a comment -

        I've just committed this. Thanks Adrian!

        Show
        Tom White added a comment - I've just committed this. Thanks Adrian!
        Hide
        Adrian Cole added a comment -

        this isn't really a bug

        Show
        Adrian Cole added a comment - this isn't really a bug
        Hide
        Adrian Cole added a comment -

        I originally hesitated to put KeyPair into the test archive as maven wasn't setup to inherit test dependencies. That said, I see you're point. I've changed the maven setup to allow test classes to be used in downstream modules, allowing KeyPair to be used in Cassandra, ZooKeeper, etc.

        As for logging, I forgot to remove the system.err.println statements. Thanks for pointing that out.

        Show
        Adrian Cole added a comment - I originally hesitated to put KeyPair into the test archive as maven wasn't setup to inherit test dependencies. That said, I see you're point. I've changed the maven setup to allow test classes to be used in downstream modules, allowing KeyPair to be used in Cassandra, ZooKeeper, etc. As for logging, I forgot to remove the system.err.println statements. Thanks for pointing that out.
        Hide
        Tom White added a comment -

        Thanks for the patch - overall it looks good.

        • KeyPair is only needed for tests so it could be in the test tree (we probably shouldn't expose it as a part of the public API).
        • Instead of the System.err.println, a log statement would be better (see WHIRR-106).
        Show
        Tom White added a comment - Thanks for the patch - overall it looks good. KeyPair is only needed for tests so it could be in the test tree (we probably shouldn't expose it as a part of the public API). Instead of the System.err.println, a log statement would be better (see WHIRR-106 ).
        Hide
        Adrian Cole added a comment -

        patch available

        Show
        Adrian Cole added a comment - patch available
        Hide
        Adrian Cole added a comment -

        this requires generating a key and exporting it to PEM format. I'll take this.

        Show
        Adrian Cole added a comment - this requires generating a key and exporting it to PEM format. I'll take this.

          People

          • Assignee:
            Adrian Cole
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development