[WEEX-474] Toast ,crash!

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.16, 0.18
• Fix Version/s: 0.18
• Component/s: Android
• Assignee: codefurture
• Reporter: 武晨
• Created: 22/Jun/18 06:39
• Updated: 31/Jul/18 03:14
• Resolved: 12/Jul/18 09:00

Description

when the app's WXInstance destroy, but Weex page call toast()，sometimes app crash, because null point exception    context is null !!!, inside toast().

 

code class WXModalUIModule:

@JSMethod(uiThread = true)
public void toast(String param) {

String message = "";
int duration = Toast.LENGTH_SHORT;
if (!TextUtils.isEmpty(param)) {
try

{ param = URLDecoder.decode(param, "utf-8"); JSONObject jsObj = JSON.parseObject(param); message = jsObj.getString(MESSAGE); duration = jsObj.getInteger(DURATION); }

catch (Exception e)

{ WXLogUtils.e("[WXModalUIModule] alert param parse error ", e); }

}
if (TextUtils.isEmpty(message))

{ WXLogUtils.e("[WXModalUIModule] toast param parse is null "); return; }

if (duration > 3)

{ duration = Toast.LENGTH_LONG; }

else

{ duration = Toast.LENGTH_SHORT; }

if (toast == null) {

//crash here!!!! sometime, mWXSDKInstance.getContext() is null  !!!!
t*oast = Toast.makeText(mWXSDKInstance.getContext(), message, duration);*
} else

{ toast.setDuration(duration); toast.setText(message); }

toast.setGravity(Gravity.CENTER, 0, 0);
toast.show();
}

 

ps：when weex page closed, and wxSDKInstance destroy，but weex page still working on background like asynchronous request(network)，on this time.when the request is back, and call toast()，now context is null，bug show!

Issue Links

• links to: GitHub Pull Request #1292
• links to: GitHub Pull Request #1292