[WAGON-585] maven.wagon.http.ssl features documentation is incomplete

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.4
• Fix Version/s: 3.4.0
• Component/s: Documentation
• Labels: newbie pull-request-available
• Flags: Patch
• Assignee: Michael Osipov
• Reporter: Alexander Kiselyov
• Created: 29/Mar/20 00:49
• Updated: 30/Mar/20 09:14
• Resolved: 30/Mar/20 09:14

Description

Description of maven.wagon.http.ssl.insecure, maven.wagon.http.ssl.allowall and maven.wagon.http.ssl.ignore.validity.dates properties is incomplete:

1. The way it is currently implemented (see org.apache.maven.wagon.shared.http.AbstractHttpClientWagon#createConnManager), latter 2 properties will not be taken into account if the insecure one is not specified (or false) - documentation does not state it clearly.
2. allowall property description mentions "browser like check," but does not give any details on what does it mean (though it may seem intuitive).

Documentation should clearly state the Wagon's behavior and how it may be altered by SSL-related properties.

 

Issue Links

• links to: GitHub Pull Request #64