[WAGON-584] LightweightHttpWagon and tests are built on false assumptions around internal buffering

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 3.3.4
• Component/s: wagon-http-lightweight
• Assignee: Unassigned
• Reporter: Michael Osipov
• Created: 19/Mar/20 08:12
• Updated: 24/Dec/23 20:14

Description

The LightweightHttpWagon heavily differs from HttpWagon internally, the way HttpURLConnection is implemented it is virtually impossible to make them behave similar (or identical).

Notable differences:

• Expect Continue is virtually not supported and signals an exception as soon as non-2xx is received
• All content is buffered in a byte array making it extremely inefficient with large uploads
• As soon as streaming mode is enabled (see HttpURLConnection#setFixedLengthStreamingMode(long) and HttpURLConnection#setChunkedStreamingMode(int)) redirect and authentication support are disabled

Tests do assume that both behave the same although HttpWagon is fully streaming while the other one is not. So, the tests are illdesigned/based on false assumptions. Run branches WAGON-584_streaming/WAGON-584_streaming_no-expect-continue and see the failures.

This behavior is nowhere documented and not properly covered in tests.