Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-496

site-deploy using wagon-ssh broke in 2.12 because of the fix for WAGON-465

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.12, 3.0.0
    • Fix Version/s: 3.1.0
    • Component/s: wagon-ssh
    • Labels:
      None

      Description

      The fix for WAGON-465 unfortunately broke backwards compatibility with version 2.10 when using maven-site-plugin together with wagon-ssh. The first commit had correct code for backwards compatibility, but that commit was reverted. The next commit did not include the correct code for backwards compatibility.

      When using wagon-ssh with maven-site-plugin the call to AbstractJschWagon.executeCommand() is done with the one-parameter version of the method. That method sets the new parameter ignoreNoneZeroExitCode to false, which results in the exit code being checked. Before WAGON-465 the exit code was never checked, it was only written to the log if there was an error message.

      For us the site-deploy succeeds with wagon 2.10 but fails with 2.12 and 3.0.0. It seems that the last chmod command returns 1 for reasons yet unknown, but it outputs no message to stderr.

      I will try to investigate why chmod returns 1 and I'll create a patch that restores the compatibility with version 2.10.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dennisl@apache.org Dennis Lundberg
                Reporter:
                dennisl@apache.org Dennis Lundberg
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: