Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-475

TransferEvent GET used instead of PUT and vice versa

        Details

          Description

          TransferEvent has REQUEST_GET and REQUEST_PUT which are intended to be used for read (GET) and write (PUT) access. Some code spots use the opposite which is apparently the wrong status:

          REQUEST_GET instead of REQUEST_PUT:

          • http.AbstractHttpClientWagon: 562, 566
          • webdav.AbstractHttpClientWagon: 361
          • scm.ScmWagon: 412, 418

          REQUEST_PUT instead of REQUEST_GET:

          • scm.ScmWagon: 412, 468

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            michael-o Michael Osipov added a comment -

            Fixed with e89c03a15d3fb0450abbd85fed45872f64686fc1.

            Show
            michael-o Michael Osipov added a comment - Fixed with e89c03a15d3fb0450abbd85fed45872f64686fc1 .
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build maven-wagon #1332 (See https://builds.apache.org/job/maven-wagon/1332/)
            WAGON-475 TransferEvent GET used instead of PUT and vice versa (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-wagon.git&a=commit&h=e89c03a15d3fb0450abbd85fed45872f64686fc1)

            • (edit) wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java
            • (edit) wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
            • (edit) wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/AbstractHttpClientWagon.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-wagon #1332 (See https://builds.apache.org/job/maven-wagon/1332/ ) WAGON-475 TransferEvent GET used instead of PUT and vice versa (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-wagon.git&a=commit&h=e89c03a15d3fb0450abbd85fed45872f64686fc1 ) (edit) wagon-providers/wagon-scm/src/main/java/org/apache/maven/wagon/providers/scm/ScmWagon.java (edit) wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java (edit) wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/AbstractHttpClientWagon.java

              People

              • Assignee:
                michael-o Michael Osipov
                Reporter:
                michael-o Michael Osipov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development