Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.10
    • Fix Version/s: 2.12
    • Component/s: wagon-ftp
    • Labels:

      Description

      Descrption

      There was a pull request created by @flavioarcega Github user for FTPS support (please note, that FTPS is something different from SFTP).

      For me the support for FTPS is also important. I'd like to use wagon-ftp extension for my project site deploying. I could use simple FTP protocol or FTPS with explicit TLS.

      actual:
      only simple FTP protocol is supported for wagon-ftp, which sends username and password in plaintext over the web

      expected:
      secure FTP client may be configured for wagon-ftp

      The sample configuration for FTPS could look like this:

      pom.xml:

      <project>
          ...
          <distributionManagement>
              ...
              <site>
                  <id>ftp.server.id</id>
                  <url>ftp://ftp.example.com</url>
              </site>
          </distributionManagement>
          ...
      </project>
      

      settings.xml:

      <settings>
          ...
          <servers>
              ...
              <server>
                  <id>ftp.server.id</id>
                  <username>username</username>
                  <password>password</password>
                  <configuration>
                      <secure>true</secure>
                  </configuration>
              </server>
          </servers>
      <settings>
      

        Issue Links

          Activity

          Hide
          wiiitek Witek added a comment -

          I have proposed pull request for this issue:

          @flavioarcega pull request may be found here

          Show
          wiiitek Witek added a comment - I have proposed pull request for this issue: https://github.com/apache/maven-wagon/pull/24 @flavioarcega pull request may be found here
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wiiitek commented on the issue:

          https://github.com/apache/maven-wagon/pull/24

          I have created JIRA issue for wagon-ftp secure support: WAGON-458(https://issues.apache.org/jira/browse/WAGON-458)

          Show
          githubbot ASF GitHub Bot added a comment - Github user wiiitek commented on the issue: https://github.com/apache/maven-wagon/pull/24 I have created JIRA issue for wagon-ftp secure support: WAGON-458 ( https://issues.apache.org/jira/browse/WAGON-458 )
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user wiiitek opened a pull request:

          https://github.com/apache/maven-wagon/pull/30

          WAGON-458 FTPSClient for Wagon

          I did deployed artifacts to some FTPS server with `endpointChecking=false`.
          This pull request still needs some testing against secure FTP server.

          Inspired by pull requests:

          After changes the configuration could look as follows:

          *pom.xml*

          ```
          <project>
          ...
          <distributionManagement>
          ...
          <site>
          <id>ftp.server.id</id>
          <url>ftps://secure.example.com</url>
          </site>
          </distributionManagement>
          ...
          </project>
          ```

          *settings.xml*

          ```
          <settings>
          ...
          <servers>
          ...
          <server>
          <id>ftp.server.id</id>
          <username>username</username>
          <password>password</password>
          <configuration>
          <endpointChecking>false</endpointChecking>
          </configuration>
          </server>
          </servers>
          <settings>
          ```

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/wiiitek/maven-wagon ftps

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/maven-wagon/pull/30.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #30


          commit 3406103faaf62c080f4d5a985886e0d6a8233250
          Author: Wiiitek <kubiczak.jakub@gmail.com>
          Date: 2016-12-02T01:45:38Z

          WAGON-458 FTPSClient for Wagon


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user wiiitek opened a pull request: https://github.com/apache/maven-wagon/pull/30 WAGON-458 FTPSClient for Wagon I did deployed artifacts to some FTPS server with `endpointChecking=false`. This pull request still needs some testing against secure FTP server. Inspired by pull requests: https://github.com/apache/maven-wagon/pull/24 https://github.com/apache/maven-wagon/pull/22 After changes the configuration could look as follows: * pom.xml * ``` <project> ... <distributionManagement> ... <site> <id>ftp.server.id</id> <url> ftps://secure.example.com </url> </site> </distributionManagement> ... </project> ``` * settings.xml * ``` <settings> ... <servers> ... <server> <id>ftp.server.id</id> <username>username</username> <password>password</password> <configuration> <endpointChecking>false</endpointChecking> </configuration> </server> </servers> <settings> ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/wiiitek/maven-wagon ftps Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-wagon/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit 3406103faaf62c080f4d5a985886e0d6a8233250 Author: Wiiitek <kubiczak.jakub@gmail.com> Date: 2016-12-02T01:45:38Z WAGON-458 FTPSClient for Wagon
          Hide
          wiiitek Witek added a comment -

          New pull request was created with simpler configuration:

          Show
          wiiitek Witek added a comment - New pull request was created with simpler configuration: https://github.com/apache/maven-wagon/pull/30
          Hide
          dantran Dan Tran added a comment -

          merged via patch method at https://github.com/apache/maven-wagon/commit/e30c31d4bd0762ec0ec54ae44fc1f3ef407c81c1

          Please close the github PR

          Thanks

          Show
          dantran Dan Tran added a comment - merged via patch method at https://github.com/apache/maven-wagon/commit/e30c31d4bd0762ec0ec54ae44fc1f3ef407c81c1 Please close the github PR Thanks
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-wagon #1317 (See https://builds.apache.org/job/maven-wagon/1317/)
          WAGON-458 FTPSClient for Wagon (dan.tran: rev e30c31d4bd0762ec0ec54ae44fc1f3ef407c81c1)

          • (add) wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpsWagon.java
          • (edit) wagon-providers/wagon-ftp/pom.xml
          • (edit) wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java
          • (edit) wagon-providers/wagon-ftp/src/site/apt/index.apt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-wagon #1317 (See https://builds.apache.org/job/maven-wagon/1317/ ) WAGON-458 FTPSClient for Wagon (dan.tran: rev e30c31d4bd0762ec0ec54ae44fc1f3ef407c81c1) (add) wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpsWagon.java (edit) wagon-providers/wagon-ftp/pom.xml (edit) wagon-providers/wagon-ftp/src/main/java/org/apache/maven/wagon/providers/ftp/FtpWagon.java (edit) wagon-providers/wagon-ftp/src/site/apt/index.apt
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pono closed the pull request at:

          https://github.com/apache/maven-wagon/pull/30

          Show
          githubbot ASF GitHub Bot added a comment - Github user pono closed the pull request at: https://github.com/apache/maven-wagon/pull/30
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wiiitek commented on the issue:

          https://github.com/apache/maven-wagon/pull/30

          Those change were cherry-picked into master branch on 2016-12-02 by commit:
          https://github.com/apache/maven-wagon/commit/e30c31d4bd0762ec0ec54ae44fc1f3ef407c81c1

          Show
          githubbot ASF GitHub Bot added a comment - Github user wiiitek commented on the issue: https://github.com/apache/maven-wagon/pull/30 Those change were cherry-picked into master branch on 2016-12-02 by commit: https://github.com/apache/maven-wagon/commit/e30c31d4bd0762ec0ec54ae44fc1f3ef407c81c1

            People

            • Assignee:
              dantran Dan Tran
              Reporter:
              wiiitek Witek
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development