Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-396

AbstractHttpClientWagon extensibility (SPNEGO Authentication)

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: wagon-http
    • Labels:
      None
    • Flags:
      Patch

      Description

      I recently implemented SPNEGO authentication for the wagon-http provider. This implementation required a extension of DefaultHttpClient. So far this support lives in a separate modules. Unfortunately overriding the client initialization is not easily possible in the current code and requires nearly full duplication of wagon-http code.

      I would suggest to move the instantiation of the client from AbstractHttpClientWagon.openConnectionInternal() into a seperate factory method, e.g.

       protected DefaultHttpClient createHttpClient( ClientConnectionManager connManager ) {
          	return new DefaultHttpClient(connManager);
          }
      
          public void openConnectionInternal()
          {
              repository.setUrl( getURL( repository ) );
              client = this.createHttpClient( getConnectionManager() );
      

      In case you are interested to integrate the SPNEGO support, I will be happy to share.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                mbechler Moritz Bechler
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: