[WAGON-396] AbstractHttpClientWagon extensibility (SPNEGO Authentication)

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.5
• Component/s: wagon-http
• Flags: Patch
• Assignee: Unassigned
• Reporter: Moritz Bechler
• Created: 16/May/13 06:31
• Updated: 19/Dec/19 12:07

Description

I recently implemented SPNEGO authentication for the wagon-http provider. This implementation required a extension of DefaultHttpClient. So far this support lives in a separate modules. Unfortunately overriding the client initialization is not easily possible in the current code and requires nearly full duplication of wagon-http code.

I would suggest to move the instantiation of the client from AbstractHttpClientWagon.openConnectionInternal() into a separate factory method, e.g.

 protected DefaultHttpClient createHttpClient( ClientConnectionManager connManager ) {
    	return new DefaultHttpClient(connManager);
    }

    public void openConnectionInternal()
    {
        repository.setUrl( getURL( repository ) );
        client = this.createHttpClient( getConnectionManager() );

In case you are interested to integrate the SPNEGO support, I will be happy to share.

Issue Links

• is related to: WAGON-522 Kerberos support doesn't work