[WAGON-275] CLONE -Fix errant exception thrown in closeConnection()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Component/s: wagon-ftp
• Assignee: Carlos Sanchez Gonzalez
• Reporter: Marcus Bates
• Created: 09/Jul/09 16:13
• Updated: 09/Jul/09 16:14
• Resolved: 09/Jul/09 16:14

Description

Fix errant exception thrown in closeConnection() of the ftp wagon which is caused by calling ftp.disconnect(). Nothing wrong seems to happen in the test. But this is what we get:

java.lang.NullPointerException
at java.io.BufferedInputStream.read(BufferedInputStream.java:205)
at java.io.FilterInputStream.read(FilterInputStream.java:66)
at java.io.PushbackInputStream.read(PushbackInputStream.java:120)
at org.apache.commons.net.io.FromNetASCIIInputStream.__read(FromNetASCIIInputStream.java:114)
at org.apache.commons.net.io.FromNetASCIIInputStream.read(FromNetASCIIInputStream.java:209)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:183)
at java.io.BufferedInputStream.read(BufferedInputStream.java:201)
at org.apache.commons.net.telnet.TelnetInputStream.__read(TelnetInputStream.java:140)
at org.apache.commons.net.telnet.TelnetInputStream.run(TelnetInputStream.java:464)
at java.lang.Thread.run(Thread.java:534)

But it seems to happen even if we don't shut down the streams so I'm not sure what's going on internally in commons-net.